-
Notifications
You must be signed in to change notification settings - Fork 117
[doc] Adapt README for dark and light Github modes #2608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I close it so that I don't spam you with my tries, the suggested way doesn't work for me for some reason. |
This reverts commit d4d9b5c.
|
In the documentation of github they suggest the |
The only problem that this has, is that because we extract the logo for the pypi installation via the README, it will show the logo twice. |
Aha, is that why we also had |
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I added an second README.md for pypi. It has the old picture so it should appear normally. It is not a great solution, because we have to maintain two READMEs, almost identical other that the picture on top. Any better idea? |
For me it's fine. I don't know how else it could work. |
Wouldn't you have the same problem with maintaining a copy of the README in parallel? How can we make sure that the copy is always updated. That's why I proposed to generate the PyPI README just before publishing if possible? |
|
In my opinion the pypi readme is not that important and we don't even need to have all the information from github. What if we have a more minimal readme for pypi that has the |
|
@ekouts Good idea! |
|
Perhaps rename it to |
@rsarm found an example from DeepSpeed's README.md https://github.com/microsoft/DeepSpeed/blob/master/README.md
You can see directly how it looks in https://github.com/ekouts/reframe/tree/dark_logo
(Hadn't noticed that there was an issue and a slightly different solution from Teo actually 😅)
Closes #2204