Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Sep 28, 2022

@rsarm found an example from DeepSpeed's README.md https://github.com/microsoft/DeepSpeed/blob/master/README.md

You can see directly how it looks in https://github.com/ekouts/reframe/tree/dark_logo

(Hadn't noticed that there was an issue and a slightly different solution from Teo actually 😅)
Closes #2204

@ekouts ekouts closed this Sep 28, 2022
@ekouts
Copy link
Contributor Author

ekouts commented Sep 28, 2022

I close it so that I don't spam you with my tries, the suggested way doesn't work for me for some reason.

@ekouts ekouts reopened this Sep 28, 2022
@ekouts
Copy link
Contributor Author

ekouts commented Sep 28, 2022

In the documentation of github they suggest the <picture> element but i couldn't make it work. I think for now #gh-dark-mode-only and #gh-light-mode-only are good enough.

@teojgo
Copy link
Contributor

teojgo commented Sep 28, 2022

In the documentation of github they suggest the <picture> element but i couldn't make it work. I think for now #gh-dark-mode-only and #gh-light-mode-only are good enough.

The only problem that this has, is that because we extract the logo for the pypi installation via the README, it will show the logo twice.

@ekouts
Copy link
Contributor Author

ekouts commented Sep 29, 2022

The only problem that this has, is that because we extract the logo for the pypi installation via the README, it will show the logo twice.

Aha, is that why we also had https://raw.githubusercontent.com/reframe/... paths instead of of relevant paths? Do you know if the picture element would solve the problem?

@ekouts ekouts requested a review from teojgo September 29, 2022 07:16
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ekouts
Copy link
Contributor Author

ekouts commented Oct 7, 2022

I added an second README.md for pypi. It has the old picture so it should appear normally. It is not a great solution, because we have to maintain two READMEs, almost identical other that the picture on top. Any better idea?

@teojgo
Copy link
Contributor

teojgo commented Oct 7, 2022

I added an second README.md for pypi. It has the old picture so it should appear normally. It is not a great solution, because we have to maintain two READMEs, almost identical other that the picture on top. Any better idea?

For me it's fine. I don't know how else it could work.

@vkarak
Copy link
Contributor

vkarak commented Oct 7, 2022

@ekouts @teojgo Couldn't that second README be generated on the fly before deployment to PyPI?

@teojgo
Copy link
Contributor

teojgo commented Oct 7, 2022

@ekouts @teojgo Couldn't that second README be generated on the fly before deployment to PyPI?

yes but this would need to happen from the github action before publishing, but I would like to avoid forgetting to update the corresponding github action if the README changes

@vkarak
Copy link
Contributor

vkarak commented Oct 7, 2022

but I would like to avoid forgetting to update the corresponding github action if the README changes

Wouldn't you have the same problem with maintaining a copy of the README in parallel? How can we make sure that the copy is always updated. That's why I proposed to generate the PyPI README just before publishing if possible?

@ekouts
Copy link
Contributor Author

ekouts commented Oct 10, 2022

In my opinion the pypi readme is not that important and we don't even need to have all the information from github. What if we have a more minimal readme for pypi that has the nutshell section + links to github and docs + the contact section about mailing list + slack etc. Like this we won't have to generate and we avoid mentioning something that is not up-to-date.

@vkarak
Copy link
Contributor

vkarak commented Oct 10, 2022

@ekouts Good idea!

@vkarak
Copy link
Contributor

vkarak commented Oct 10, 2022

Perhaps rename it to README_minimal.md instead of README_pypi.md.

@vkarak vkarak changed the title [doc] Add reframe logo for dark and light mode [doc] Adapt README for dark and light Github modes Oct 10, 2022
@vkarak vkarak merged commit 291e93b into reframe-hpc:master Oct 10, 2022
@ekouts ekouts deleted the dark_logo branch March 13, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame logo in README does not show up correctly in Github's dark mode

5 participants