[test] Add optional validation -c option to the OSU hpclib tests
#2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can I test this patch? |
rsarm
changed the title
-c option to the OSU tests-c option to the OSU hpclib tests
Contributor
|
Ok to test |
Contributor
|
I agree. I think it's a good idea. @mszpindler had told me about it offline. |
vkarak
requested changes
Oct 25, 2022
| #: | ||
| #: :type: `bool` | ||
| #: :default: ``False`` | ||
| validation = variable(bool, value=False) |
Contributor
There was a problem hiding this comment.
I think that we should not use an extra variable then and always run with the -c option. Therefore, we should also keep only the new validation test.
Contributor
|
@mszpindler I have made a PR (Lumi-supercomputer#8) to your branch with my suggestion to use always the |
Contributor
|
Replaced by #2679. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose optional
validationparameter for the checks class that enables built-in OSU validation.