[bugfix] Restrict reference tuples acceptable types #2702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reference tuples cannot accept a deferrable.
This is achieved nicely by extending the type checking system to support
composite types and by allowing to insert in the type check subsystem any custom
type. For example, one can do the following:
```python
Deferrable = typ.make_meta_type('Deferrable', _DeferredExpression)
x = variable(typ.Integer|Deferrable|typ.List[typ.Integer|typ.Float])
y = variable(~typ.Deferrable)
```
vkarak
force-pushed
the
bugfix/restrict-reference-types
branch
from
7df66a1 to
519bc9f
Compare
victorusu
reviewed
Dec 9, 2022
ekouts
requested changes
Dec 13, 2022
Contributor
ekouts
left a comment
ekouts
left a comment
There was a problem hiding this comment.
lgtm, just a small comment about imports
ekouts
approved these changes
Dec 13, 2022
Contributor
|
@jenkins-cscs retry all |
Codecov ReportBase: 86.59% // Head: 86.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
- Coverage 86.59% 86.59% -0.01%
==========================================
Files 60 60
Lines 11198 11223 +25
==========================================
+ Hits 9697 9718 +21
- Misses 1501 1505 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference tuples cannot accept a deferrable as their elements.
This is achieved nicely by extending the type checking system to support composite types and by allowing to insert in the type check subsystem any custom type. For example, one can do the following:
This mechanism allows us to remove the
other_typeargument ofTypedField, but it will probably break existingvariabledefinitions of users.Fixes #2630.