[bugfix] Properly set display name of tests with join fixtures #2705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test had a join fixture over a parameterised test, whose parameterisation space is a single point only, ReFrame will erroneously include the fixture's parameter name in the display name of the test that is using it. This is not correct as tests with join fixtures do not inherit the fixture parameters. This bug was due to how
display_namewas checking if a fixture was a join or not; it was relying on theget_variant_info()information, which encodes the fixture space as a tuple only if it has more than two points. We instead use a much more robust check by checking directly theactionof the fixture instance. The same bug was present also when constructing theFixtureProxyto allow early access to fixtures. Early access to join fixtures is not allowed, but the current implementation was giving access to join fixtures with a single point fixture space.This is an example to demonstrate the display name before and after. Given the following test:
This lists
mytestas follows ifphas a single value:But if
phas more than two values, then this is how it is displayed:This PR fixes the first case and now the display name is as expected: