[bugfix] Fix hash clashes for parameterised tests #2714
Merged
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
changed the title
vkarak
force-pushed
the
bugfix/hash-conflicts
branch
from
b235dd0 to
d680e75
Compare
Codecov ReportBase: 86.57% // Head: 86.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2714 +/- ##
==========================================
+ Coverage 86.57% 86.61% +0.03%
==========================================
Files 60 60
Lines 11213 11213
==========================================
+ Hits 9708 9712 +4
+ Misses 1505 1501 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ekouts
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working with parameterised tests, I noticed some hash clashes, where a test with a single parameter value was being assigned the same hash even if the parameter value changed. It turned out the bug was a missing
()! Thehashcodeproperty was treatingis_fixtureas a property instead of a function, so the test was always returning true, thus the has was actually being computed based on the test's unique name and not based on its display name... I've added a unit test to avoid that from happening again.