[bugfix] Fix cleanup crash for non-performance tests when the perflog_compat option is on

[ekouts]

This is first attempt to fix the bug, but maybe we should investigate more:

1. how to handle errors in log_performance. It's not a good idea to completely suppress them, because the error that ReFrame gives in this case can be very confusing
2. if it's correct to have check == None for non-performance tests

Fixes #2715 .

[teojgo]

I think that what you need to do is to check:

self.check.is_performance_check()

And perform the performance logging in

reframe/reframe/frontend/executors/__init__.py

Line 389 in 1724a35

self._perflogger.log_performance(logging.INFO, self,

only when it is actually a performance check. If it's not a performance test, then the perflogger will not have been set properly with the check name here:

reframe/reframe/frontend/executors/__init__.py

Line 372 in 1724a35

self._perflogger = logging.getperflogger(self.check)

[ekouts]

I think that what you need to do is to check:

self.check.is_performance_check()

And perform the performance logging in

reframe/reframe/frontend/executors/__init__.py

Line 389 in 1724a35

self._perflogger.log_performance(logging.INFO, self,

only when it is actually a performance check. If it's not a performance test, then the perflogger will not have been set properly with the check name here:

reframe/reframe/frontend/executors/__init__.py

Line 372 in 1724a35

self._perflogger = logging.getperflogger(self.check)

Yes, I think your solution is nicer. I fixed it