Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jan 14, 2023

We now use re.search() instead of re.match() for matching the name or tag patterns in the related cli options. So there is no need any more to prepend .* to a name pattern so as to match something in the middle of the test name.

Closes #2658

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023

Codecov Report

Base: 86.61% // Head: 86.61% // No change to project coverage 👍

Coverage data is based on head (d2ea0d6) compared to base (db171e7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2736   +/-   ##
========================================
  Coverage    86.61%   86.61%           
========================================
  Files           60       60           
  Lines        11215    11215           
========================================
  Hits          9714     9714           
  Misses        1501     1501           
Impacted Files Coverage Δ
reframe/frontend/filters.py 98.64% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit d31f4cd into reframe-hpc:develop Jan 19, 2023
@vkarak vkarak deleted the enhancement/improve-name-matching branch January 19, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use search instead of match when matching regexes for the various command line options

4 participants