Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jan 25, 2023

Fixes #2745.

@flx42 Could you test this, as I don't have access to a Slurm cluster as a privileged user?

@vkarak vkarak added this to the ReFrame 4.1 milestone Jan 25, 2023
@vkarak vkarak requested review from ekouts and victorusu January 25, 2023 22:22
@vkarak vkarak self-assigned this Jan 25, 2023
@flx42
Copy link

flx42 commented Jan 25, 2023

It works, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Base: 86.61% // Head: 86.61% // No change to project coverage 👍

Coverage data is based on head (d319186) compared to base (09bf7df).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2766   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          60       60           
  Lines       11213    11213           
=======================================
  Hits         9712     9712           
  Misses       1501     1501           
Impacted Files Coverage Δ
reframe/frontend/cli.py 73.67% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vkarak vkarak merged commit f5f6a31 into reframe-hpc:master Jan 26, 2023
@vkarak vkarak deleted the bugfix/job-options-neg-values branch January 26, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants