Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Feb 1, 2023

The fix turned out to be easy, since we were already storing the unset variables. This is now moved at the loader level and we warn only after all test filtering has happened in the cli (but before the treatment of the special options --failed, --distribute and --repeat).

Fixes #2672.

@vkarak vkarak added this to the ReFrame 4.1 milestone Feb 1, 2023
@vkarak vkarak requested review from ekouts, teojgo and victorusu February 1, 2023 22:45
@vkarak vkarak self-assigned this Feb 1, 2023
@vkarak vkarak changed the title [bugfix] Warn for unset variables only for the tests that will be actually executed [bugfix] Warn for unset variables only for the tests that are selected Feb 1, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 86.61% // Head: 86.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b9a2cc3) compared to base (def32e3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2774   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          60       60           
  Lines       11214    11218    +4     
=======================================
+ Hits         9713     9717    +4     
  Misses       1501     1501           
Impacted Files Coverage Δ
reframe/frontend/cli.py 73.84% <100.00%> (+0.16%) ⬆️
reframe/frontend/loader.py 96.02% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vkarak vkarak merged commit bcf1a4c into reframe-hpc:master Feb 2, 2023
@vkarak vkarak deleted the bugfix/restrict-unset-vars-warning branch February 2, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants