[bugfix] Do not issue a name conflict error for the same fixture imported from different test files

[teojgo]

Fixes #2759

• Create unittest

[codecov-commenter]

Codecov Report

Base: 86.61% // Head: 86.58% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (8b3c8d3) compared to base (a96aec5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2780      +/-   ##
==========================================
- Coverage   86.61%   86.58%   -0.04%     
==========================================
  Files          60       60              
  Lines       11218    11230      +12     
==========================================
+ Hits         9717     9723       +6     
- Misses       1501     1507       +6     

Impacted Files	Coverage Δ
reframe/frontend/loader.py	96.10% <100.00%> (+0.07%)	⬆️
reframe/frontend/cli.py	73.22% <0.00%> (-0.62%)	⬇️
reframe/core/logging.py	81.02% <0.00%> (+0.03%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ekouts]

Would it be easy to make the PR to master, since it is a bugfix? Otherwise, it looks good to me

[vkarak]

I think you started off the branch from the develop and now trying to merge with master. You should branch off master and apply your changes there.

[vkarak]

I think that this fix introduces another bug. :-) The reason that the framework refuses to run tests with conflicting names is because they cannot execute safely in parallel, as they will step on each other in the stage directory. This fix basically allows conflicting tests defined in different files to run together, which is wrong. However, the problem in #2759 is that fixtures with the same name are disallowed. This is a bug, because fixtures with the same name (i.e., with the same scope and same variables defined) are guaranteed to run only once, so the framework should not complain about them being defined multiple times. Therefore the fix should be to ignore name conflicts in case of fixtures as fixtures are guaranteed to get a unique name and each one of those will be executed once per scope.