[enhancement] Raise warning for invalid mode cli option #2790
+30
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
requested changes
Feb 15, 2023
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I suggest opening this PR against master, as it's not a new feature.
Signed-off-by: Theofilos Manitaras <manitaras@cscs.ch>
teojgo
force-pushed
the
enhancement/warn_invalid_mode
branch
from
ff94405 to
8fd32d4
Compare
vkarak
changed the title
vkarak
approved these changes
Feb 15, 2023
Codecov ReportBase: 86.57% // Head: 86.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2790 +/- ##
=======================================
Coverage 86.57% 86.58%
=======================================
Files 60 60
Lines 11229 11232 +3
=======================================
+ Hits 9722 9725 +3
Misses 1507 1507
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2789