Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Feb 22, 2023

No description provided.

@teojgo teojgo added this to the ReFrame 4.1 milestone Feb 22, 2023
@teojgo teojgo requested review from ekouts and vkarak February 22, 2023 14:27
@teojgo teojgo self-assigned this Feb 22, 2023
@teojgo teojgo force-pushed the bugfix/list_nonfixt_deps branch 2 times, most recently from 9213b64 to 095de64 Compare February 22, 2023 14:32
Signed-off-by: Theofilos Manitaras <manitaras@cscs.ch>
@teojgo teojgo force-pushed the bugfix/list_nonfixt_deps branch from 095de64 to 6d9fb21 Compare February 22, 2023 14:33
@vkarak
Copy link
Contributor

vkarak commented Feb 22, 2023

@teojgo Can you explain a bit what problem this PR solves?

@vkarak vkarak changed the title [bugfix] Fix listing on non-fixture dependencies [bugfix] Fix listing of non-fixture-based dependencies Feb 22, 2023
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should add a small cli test that lists test with dependencies, e.g., ./bin/reframe -c unittests/resources/checks_unlisted/deps_complex.py -l

Signed-off-by: Theofilos Manitaras <manitaras@cscs.ch>
@teojgo
Copy link
Contributor Author

teojgo commented Feb 23, 2023

@teojgo Can you explain a bit what problem this PR solves?

It fixes the problem where during listing, ReFrame tries to access fixture data even for non fixture tests.

@codecov-commenter
Copy link

Codecov Report

Base: 86.58% // Head: 86.75% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (d9787b0) compared to base (facdd8b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
+ Coverage   86.58%   86.75%   +0.17%     
==========================================
  Files          60       60              
  Lines       11233    11237       +4     
==========================================
+ Hits         9726     9749      +23     
+ Misses       1507     1488      -19     
Impacted Files Coverage Δ
reframe/frontend/cli.py 76.47% <100.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vkarak vkarak merged commit ce69b73 into reframe-hpc:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants