[bugfix] Allow proper assignment of time_limit from command line
#2823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the same problem for all other
TimerFieldvariables.To allow setting these fields properly from the command line, we get rid of the
TimerFieldand replace it with the augmented typeDuration, which is similar in concept with theBooltype. This type allows conversion from floats, int and strings and applies essentially the logic of the formerTimerField. Since for this field we want to allow conversions also when it's set from inside the test, e.g.,time_limit = '10s', we add a new argumentallow_implicitto theTypedFieldconstructor (also exposed through thevariablebuiltin), which make the field try implicit conversions before assigning the value to the test attribute. Therefore a variable declared asx = variable(int, allow_implicit=True)can be set with eitherx = 1orx = '1'.Closes #2815.