Skip to content

optimized get API #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2023
Merged

optimized get API #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c3a7ec
optimized `get` API
May 15, 2023
b6fd6b0
tirvial
May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions examples/cpp/cxx_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,23 @@ int main()
<< "returned: "
<< hp->get("x.y.z", "false") << std::endl;

// ======= opt api test =======

PUTPARAM(xacc.eager, false);
PUTPARAM(xacc.lazy.device, "xla");

std::string device_type = GETPARAM(xacc.lazy.device, "xpu");
std::cout << "\n:: (opt api) test put parameter" << std::endl
<< "expected: xla" << std::endl
<< "returned: " << device_type << std::endl
<< "expected: 0" << std::endl
<< "returned: " << GETPARAM(xacc.eager, true) << std::endl;

std::cout << "\n:: (opt api) test undefined" << std::endl
<< "expected: 100" << std::endl
<< "returned: " << GETPARAM(xacc.dynamo.time, 100) << std::endl;

std::cout << "in main" << std::endl;

return 0;
}
17 changes: 16 additions & 1 deletion hyperparameter/hyperparameter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace hyperparameter
{
return finalize((len >= 32 ? h32bytes(p, len, seed) : seed + PRIME5) + len, p + (len & ~0x1F), len & 0x1F);
}

private:
static constexpr uint64_t PRIME1 = 11400714785074694791ULL;
static constexpr uint64_t PRIME2 = 14029467366897019727ULL;
Expand Down Expand Up @@ -191,6 +191,21 @@ namespace hyperparameter
{
return storage_put_str(_storage, key, val);
}

std::shared_ptr<hyperparameter::Hyperparameter> get_hp() {
static std::shared_ptr<Hyperparameter> hp;
if (!hp) {
hp = hyperparameter::create_shared();
}
return hp;
}
}

#define GETHP hyperparameter::get_hp()

// Implicit create hyperparameter object
#define GETPARAM(p, default_val) \
(GETHP->get(([](){ constexpr uint64_t x = hyperparameter::xxhash(#p,sizeof(#p)-1); return x;})(), default_val))
#define PUTPARAM(p, default_val) (GETHP->put(#p, default_val))

#endif