Skip to content

fix(universes): Update GameJoinRestriction interface #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marinofranz merged 1 commit into from
Nov 17, 2025
Merged

fix(universes): Update GameJoinRestriction interface #7

marinofranz merged 1 commit into from
Nov 17, 2025

Conversation

@commonly-ts
Copy link
Contributor

@commonly-ts commonly-ts commented Nov 16, 2025 •
edited
Loading

Description

Makes the duration property optional to align with the API.

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Changes Made

  • duration inside GameJoinRestriction is now optional

Testing

  • All existing tests pass (pnpm test)
  • Tested manually (describe below)

Manual Testing

// Example code showing how you tested this change

Code Quality

  • My code follows the project's coding style
  • I have run pnpm lint and fixed any issues
  • I have run pnpm format to format my code
  • I have run pnpm typecheck and there are no type errors
  • I have reviewed my own code

Documentation

  • I have updated the relevant documentation (if applicable)
  • I have added/updated JSDoc comments for new/modified code

Additional Context

image

Checklist

  • I have read the CONTRIBUTING.md guide
  • My PR title follows the Conventional Commits format
  • I have rebased my branch on the latest main branch
  • I have tested my changes against the Roblox Open Cloud API (if applicable)
  • This PR is ready for review

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@marinofranz
Copy link
Member

marinofranz commented Nov 16, 2025

Is this meant to be marked as a draft PR?

@marinofranz marinofranz added the bug Something isn't working label Nov 16, 2025
@commonly-ts
Copy link
Contributor Author

commonly-ts commented Nov 16, 2025

Is this meant to be marked as a draft PR?

It is marked as a draft PR

@marinofranz
Copy link
Member

marinofranz commented Nov 16, 2025

Is this meant to be marked as a draft PR?

It is marked as a draft PR

Is this ready for review? A draft PR means it's still a work in progress

@commonly-ts
Copy link
Contributor Author

commonly-ts commented Nov 16, 2025

Is this meant to be marked as a draft PR?

It is marked as a draft PR

Is this ready for review? A draft PR means it's still a work in progress

I just haven't done the tests and formatting commands. I'll edit in the manual test later.

@marinofranz
Copy link
Member

marinofranz commented Nov 16, 2025

Is this meant to be marked as a draft PR?

It is marked as a draft PR

Is this ready for review? A draft PR means it's still a work in progress

I just haven't done the tests and formatting commands. I'll edit in the manual test later.

Ah, no need for that, it's a very simple interface adjustment, you can turn this into a normal PR and we'll get this merged 😄

@commonly-ts commonly-ts marked this pull request as ready for review November 17, 2025 00:12
marinofranz
marinofranz approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@marinofranz marinofranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@marinofranz marinofranz merged commit 5fc1c32 into relatiocc:main Nov 17, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 17, 2025
@semantic-release-bot
chore(release): 1.10.1 [skip ci]
15315ba 
## [1.10.1](v1.10.0...v1.10.1) (2025-11-17)

### Bug Fixes

* **universes:** make GameJoinRestriction duration optional ([5fc1c32](5fc1c32)), closes [#7](#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marinofranz marinofranz marinofranz approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@commonly-ts @marinofranz