-
Notifications
You must be signed in to change notification settings - Fork 1
Rel 1143044 port diagram #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates to the diagram are nearly correct. The general idea is to modify the diagram so that it only shows Elasticsearch ports. It shouldn't be called "Datagrid" or "EW" or "Environment Watch" etc. Refer back to the Acceptance Criteria...
The AC explicitly wants you to completely eliminate DG from the table/diagram and replace it with these 3:
- Elastic Stack - Elasticsearch - (9200)
- Elastic Stack - Kibana - (5601)
- Elastic Stack - Apm-Server - (8200)
On the subject of public documentation and acronyms, you must avoid using "EW" altogether. The diagram should ONLY include Elasticsearch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve this PR with the understanding you will do your best to address the comment on having only 3 entries within the table and diagram indicating the Elastic Stack (e.g. Elasticsearch/Kibana/APM Server). When @KarunaDhawan returns next week, there will likely be a single PR open to address key edits and/or final structure changes.
Hi @scott-parillo, Earlier I have done as per AC, later was suggested to have additional 3 and verify with you once. Now, updated as per AC. Additional Port number 9300-9400 for elasticsearch being added as intercommunication of ElasticSearch Nodes Thanks |
|
In addition to REL-1143044, few changes are being added as suggested in #24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have reviewed the port diagram and environment size references with Engineer for the https://github.com/relativitydev/server-bundle-release/blob/9b4e56d379d76047d4783103838c237e7d1a9769/docs/environment-watch/port-diagram.md
Approving in the absence of Karuna for this sub task.


A new ./server-bundle-release/docs/environment-watch/port-diagram.md page created
Renamed the "elasticsearch_setup.md" to "elasticsearch_pre_installation_overview.md"
In "elasticsearch_pre-installation-overview.md" added a Port diagram under the "Before You Start" section, a new bullet added as the second bullet with a link to the portdiagram.md page.
For the existing Kibana/elasticsearch/apm-server setup instructions added hyperlink of Port diagram as a first step :
Added a Banner before Installation steps - "Ensure inbound/outbound ports are open for this elastic stack component"
Added System Requirements Section that detail following
Relativity Version
Elasticsearch Version for Environment Watch : updated 1 singular version which is supported.