Skip to content

Update go #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2022
Merged

Update go #2

merged 1 commit into from
May 3, 2022

Conversation

meggers
Copy link
Collaborator

@meggers meggers commented May 1, 2022

No description provided.

@meggers meggers changed the base branch from main to add-release-action May 2, 2022 13:28
@meggers meggers requested a review from a team May 2, 2022 13:28
HawaiianSpork
HawaiianSpork approved these changes May 2, 2022
View reviewed changes
Copy link

@HawaiianSpork HawaiianSpork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is there a reason you removed the test step in the job?

@meggers
Copy link
Collaborator Author

meggers commented May 2, 2022

Looks good, is there a reason you removed the test step in the job?

Tests are run as part of the docker build, it didn't seem necessary to run them twice. Thoughts?

@HawaiianSpork
Copy link

Looks good, is there a reason you removed the test step in the job?

Tests are run as part of the docker build, it didn't seem necessary to run them twice. Thoughts?

That works for me.

Base automatically changed from add-release-action to main May 3, 2022 12:34
@meggers meggers merged commit a7abc58 into main May 3, 2022
@meggers meggers deleted the update-go branch May 3, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HawaiianSpork HawaiianSpork HawaiianSpork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meggers @HawaiianSpork