Skip to content

refactor: name our executors #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

refactor: name our executors #102

merged 1 commit into from
Jul 13, 2021

Conversation

@rohanpm
Copy link
Contributor

@rohanpm rohanpm commented Jul 12, 2021

Naming our executors is a good idea because:

  • the name will be reused in any created threads, so we can
    figure out which code created which thread

  • the name will appear in prometheus metrics

@rohanpm
refactor: name our executors
df09689 
Naming our executors is a good idea because:

- the name will be reused in any created threads, so we can
  figure out which code created which thread

- the name will appear in prometheus metrics
@rohanpm rohanpm marked this pull request as ready for review July 12, 2021 05:00
@rohanpm rohanpm requested a review from a team July 12, 2021 05:01
@rohanpm rohanpm merged commit 4ba7c47 into release-engineering:master Jul 13, 2021
@rohanpm rohanpm deleted the name-executors branch July 13, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@negillett negillett negillett approved these changes

@rbikar rbikar rbikar approved these changes

@rajulkumar rajulkumar Awaiting requested review from rajulkumar rajulkumar is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohanpm @negillett @rbikar