Support uploading content to pulp #30
Conversation
Implemented basic uploading functionality, which could upload a single file to pulp.
1. bump version and update CHANGELOG.md 2. move the upload api to FileRepository class 3. remove some unused arguments for importing to iso repo 4. upload/import file to Pulp is still blocking style, the api is just for import 1 file, if users want to import many files at the same time, should wrap it in threads 5. read file with binary mode 6. add verifications in test
various small fixes will add example and add more test cases if the idea here's OK
style with upload by chunk in sequence
JayZ12138
requested review from
alexandrevicenzi,
danrodrig,
midnightercz,
negillett and
rbikar
|
about if fails the import task when repo doesn't exist in the fake client, I realized it's necessary after I left the comment and then deleted it, which caused confusion that it's in the email but can't find it in pull request anymore. |
rohanpm
left a comment
rohanpm
left a comment
There was a problem hiding this comment.
The example is now working for me locally.
I think this is close to merge, but I would rather not have all the intermediate commits in history, do you want to rebase and clean up the git history yourself or should we do it at merge time?
| "--password", help="Pulp password (or set PULP_PASSWORD in env)" | ||
| ) | ||
| parser.add_argument("--debug", action="store_true") | ||
| parser.add_argument("--verify", default=False, action="store_true") |
There was a problem hiding this comment.
Can you please invert this so that it verifies by default?
If in doubt, copy the option name from an existing command. e.g. curl uses -k, --insecure.
There was a problem hiding this comment.
hm, it's weird that I have already done the changes on my side and pushed, but it doesn't change in this pull request. Not sure why.
- add verify option to upload-files - fix path error in upload-files - 'digest' should rather be 'checksum' in unit_key in import request - fix url error for upload
Yeah. I guess 'squash and merge' while doing merge will work? |
|
Since the change in example/uploads-files didn't show, I'm closing it and reopen a new one. |
2 participants
Pull request re-open for the one merged by mistake