Support upload to pulp #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented basic uploading functionality, which could upload a single file to pulp.
1. bump version and update CHANGELOG.md 2. move the upload api to FileRepository class 3. remove some unused arguments for importing to iso repo 4. upload/import file to Pulp is still blocking style, the api is just for import 1 file, if users want to import many files at the same time, should wrap it in threads 5. read file with binary mode 6. add verifications in test
various small fixes will add example and add more test cases if the idea here's OK
style with upload by chunk in sequence
- add verify option to upload-files - fix path error in upload-files - 'digest' should rather be 'checksum' in unit_key in import request - fix url error for upload
rohanpm
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.