Allow searching on model fields rather than (only) raw Pulp fields #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the real client, if you'd passed a bad criteria object, you'd immediately get an exception. On the fake client, you'd rather get a future resolved with an exception. It's best to be consistent between the two clients, so let's adjust the fake client to also raise immediately. We can share the real client code to do this.
Previously, it was necessary always to use Pulp field names in repo searches. This was awkward, as it means the caller needs to know and deal with both the Pulp and the model field names for the same piece of data. For example, to find Repository objects with eng_product_id=123, the caller would have to know that this field is stored as a string under "notes.eng_product", thus the model wouldn't fully encapsulate the Pulp implementation details. Improve this by making it possible to provide the model field names to searches. If the caller wants to find repositories with (for example) eng_product_id=123, they can now directly search with that field name and value. This should be preferred, as the caller no longer has to know exactly how a field has been stored within Pulp. However, since it's not usable under all circumstances, search on raw Pulp fields will remain supported.
Contributor
Author
|
@rajulkumar this is supposed to help you completely scrap the need to embed "notes.pub_temp_repo" anywhere, so it's fully encapsulated by this library. |
rajulkumar
reviewed
Aug 15, 2019
| from pubtools.pulplib._impl.client.search import filters_for_criteria | ||
|
|
||
|
|
||
| def test_eng_product_in(): |
Contributor
There was a problem hiding this comment.
minor: 'test_eng_product_id'
Contributor
Author
There was a problem hiding this comment.
Actually I did mean "in" because the test is doing a search with "in" operator, though I see how it's ambiguous.
Contributor
There was a problem hiding this comment.
I see what you mean. It's called eng_product_id, so looked like a typo.
rajulkumar
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to search directly for e.g. "is_temporary", rather than having to know the
underlying field in which that data is stored, "notes.pub_temp_repo".
This reduces dependency on Pulp implementation details.