Fix handling of errors with response=None #67
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our retry policy has custom handling for 404 responses.
The code for that had wrongly assumed that, whenever an exception
had a response attribute, that attribute would be something
other than None.
In practice, the response is None for certain exceptions generated
by the requests library where a failure occurred before a response
was available (e.g. SSL handshake errors, I/O errors). Make sure
we tolerate this, so those exceptions propagate correctly rather
than being transformed to an internal error in the retry policy.