Ensure Matcher.regex raises when passed non-string #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matcher.regex is documented as accepting a string, but previously
if you passed an already-compiled regex, that would also be
accepted by the validator. This happened because re.compile simply
returns already-compiled regexes without an error. It would
ultimately lead to an error when executing a search, because a
compiled regex is not serializable to JSON.
Fix it to more strictly typecheck the inputs when creating the
matcher, so we fail early and with a meaningful message.