Fix export an empty maintenance would crash

[JayZ12138]

Now if the report is empty and last_updated field is None, then while
exporting report, current datetime will be used to aviod crashing.

[rajulkumar]

may validate the last_updated as current date as well

[JayZ12138]

I didn't remember how the timestamp was tested..., in this case, what I can think of is mock the datetime.datetime.utcnow() with a fake timestamp and check it, but doesn't make much sense to me. Do you think this is good or just a waste of lines? any other test methods?

[JayZ12138]

I guess I can check the output timestamp, see if it's a timestamp with right format.

[rajulkumar]

Checking the timestamp to be the current time/mocked time in case of an empty report would have been better. But looking at the bigger picture, adding the timestamp is to ensure the report doesn't crash. So checking if timestamp exist should be fine too.

[rajulkumar]

current_date = datetime.datetime.now()
    with patch.object(datetime, "datetime", Mock(wraps=datetime.datetime)) as mocked_datetime:
        mocked_datetime.now.return_value = current_date
        report = MaintenanceReport()._export_dict()

    assert report.get('last_updated') == datetime.datetime.strftime(current_date, "%Y-%m-%dT%H:%M:%SZ")

This is what I did though to check current time

[rajulkumar]

I think it will be better to keep this method generic and move setting the value to current date in _export_dict()

[JayZ12138]

Hm, I did it here since the MaintenanceEntry object could also have the same problem, which has a timestamp, defaulted to None as well.

[rajulkumar]

That sounds fair. Since this is a generic method and not tied to maintenance_report only, please modify this comment to something like "defaults to current time if value is None"

[JayZ12138]

makes sense.