Fix unit search criteria [DELIVERY-7839] #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes changes to Client._search to prepare criteria for unit searches along with some reorganization of the method.
negillett
requested review from
jbruzl,
rajulkumar and
rohanpm
as code owners
negillett
requested review from
JayZ12138,
chandwanitulsi,
danrodrig,
lipoja,
midnightercz and
rbikar
JayZ12138
approved these changes
Dec 17, 2019
Member
Author
|
@jbruzl, this PR needs approval from a code owner and essentially just fixes something overlooked in the previous PR for DELIVERY-7839. |
Member
Author
|
@release-engineering/content-delivery, this still needs code owner review |
midnightercz
approved these changes
Jan 3, 2020
jbruzl
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes changes to Client._search to prepare criteria for unit
searches along with some reorganization of the method.