refactor: deduplicate fixtures in errata tests

tests/errata/conftest.py

@@ -0,0 +1,26 @@
+from pytest import fixture
+from mock import patch
+
+from .fake_errata_tool import FakeErrataToolController
+from ..koji.fake_koji import FakeKojiController
+
+
+@fixture
+def fake_errata_tool():
+    controller = FakeErrataToolController()
+    with patch("pushsource._impl.backend.errata_source.ServerProxy") as mock_proxy:
+        mock_proxy.side_effect = controller.proxy
+        yield controller
+
+
+@fixture
+def fake_koji():
+    controller = FakeKojiController()
+    with patch("koji.ClientSession") as mock_session:
+        mock_session.side_effect = controller.session
+        yield controller
+
+
+@fixture
+def koji_dir(tmpdir):
+    yield str(tmpdir.mkdir("koji"))

tests/errata/test_errata_errors.py

@@ -1,19 +1,8 @@
-from pytest import raises, fixture
-from mock import patch
-
-from .fake_errata_tool import FakeErrataToolController
+from pytest import raises
 
 from pushsource import Source, ErratumPushItem, ErratumReference, RpmPushItem
 
 
-@fixture
-def fake_errata_tool():
-    controller = FakeErrataToolController()
-    with patch("pushsource._impl.backend.errata_source.ServerProxy") as mock_proxy:
-        mock_proxy.side_effect = controller.proxy
-        yield controller
-
-
 def test_errata_files_needs_koji_url(fake_errata_tool):
     """Can't obtain errata referring to files if koji source URL is missing"""
 

tests/errata/test_errata_metadata.py

@@ -1,19 +1,6 @@
-from pytest import raises, fixture
-from mock import patch
-
-from .fake_errata_tool import FakeErrataToolController
-
 from pushsource import Source, ErratumPushItem, ErratumReference
 
 
-@fixture
-def fake_errata_tool():
-    controller = FakeErrataToolController()
-    with patch("pushsource._impl.backend.errata_source.ServerProxy") as mock_proxy:
-        mock_proxy.side_effect = controller.proxy
-        yield controller
-
-
 def test_errata_typical_metadata(fake_errata_tool):
     """Test fetching an advisory with no files:
 

tests/errata/test_errata_modules.py

@@ -1,9 +1,4 @@
 import os
-from pytest import raises, fixture
-from mock import patch
-
-from .fake_errata_tool import FakeErrataToolController
-from ..koji.fake_koji import FakeKojiController
 
 from pushsource import (
     Source,
@@ -16,27 +11,6 @@
 )
 
 
-@fixture
-def fake_errata_tool():
-    controller = FakeErrataToolController()
-    with patch("pushsource._impl.backend.errata_source.ServerProxy") as mock_proxy:
-        mock_proxy.side_effect = controller.proxy
-        yield controller
-
-
-@fixture
-def fake_koji():
-    controller = FakeKojiController()
-    with patch("koji.ClientSession") as mock_session:
-        mock_session.side_effect = controller.session
-        yield controller
-
-
-@fixture
-def koji_dir(tmpdir):
-    yield str(tmpdir.mkdir("koji"))
-
-
 def test_errata_modules_via_koji(fake_errata_tool, fake_koji, koji_dir):
     """Errata source containing a module yields modules & RPMs taken
     from koji source"""

tests/errata/test_errata_rpms.py

@@ -1,9 +1,4 @@
 import os
-from pytest import raises, fixture
-from mock import patch
-
-from .fake_errata_tool import FakeErrataToolController
-from ..koji.fake_koji import FakeKojiController
 
 from pushsource import (
     Source,
@@ -15,27 +10,6 @@
 )
 
 
-@fixture
-def fake_errata_tool():
-    controller = FakeErrataToolController()
-    with patch("pushsource._impl.backend.errata_source.ServerProxy") as mock_proxy:
-        mock_proxy.side_effect = controller.proxy
-        yield controller
-
-
-@fixture
-def fake_koji():
-    controller = FakeKojiController()
-    with patch("koji.ClientSession") as mock_session:
-        mock_session.side_effect = controller.session
-        yield controller
-
-
-@fixture
-def koji_dir(tmpdir):
-    yield str(tmpdir.mkdir("koji"))
-
-
 def test_errata_rpms_via_koji(fake_errata_tool, fake_koji, koji_dir):
     """Errata source yields RPMs taken from koji source"""