errata: support FTP paths for RPMs #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanpm
force-pushed
the
rohan/errata-ftp-paths
branch
from
48f7a8b to
766c423
Compare
rbikar
approved these changes
Jun 8, 2021
rohanpm
force-pushed
the
rohan/set-module-nsvca
branch
from
82a2a1f to
758b74a
Compare
Integrate support for get_ftp_paths API into errata backend. This can now result in the 'dest' for one RPM push item having a mixture of rhsm-pulp repo IDs and FTP paths. This will allow alt-src pushes to work on top of errata backend. Other tweaks include: - drop the 'target' argument to errata backend (which was not used). It seems we ought not to need this. For now the design now is that the source will give you back all kinds of destinations (and if you only want to deal with certain types, e.g. you don't want the ftp paths, you need to filter them yourself). It's possible some optional filtering arguments will be added here later. - separate the low-level code which calls ET methods into a new errata_client module Note: the backend remains marked as a technical preview with no stability guarantee.
rohanpm
force-pushed
the
rohan/errata-ftp-paths
branch
from
766c423 to
552c53e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate support for get_ftp_paths API into errata backend.
This can now result in the 'dest' for one RPM push item having
a mixture of rhsm-pulp repo IDs and FTP paths. This will allow
alt-src pushes to work on top of errata backend.
Other tweaks include:
drop the 'target' argument to errata backend (which was not used).
It seems we ought not to need this.
For now the design now is that the source will give you back all
kinds of destinations (and if you only want to deal with certain
types, e.g. you don't want the ftp paths, you need to filter them
yourself). It's possible some optional filtering arguments will be
added here later.
separate the low-level code which calls ET methods into a new
errata_client module
Note: the backend remains marked as a technical preview with
no stability guarantee.