Fix missing deps and do manual pip-compile #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies in CI haven't been updated in this repo for a while because dependabot broke (unable to install rpm-py-installer). Fixing this is a goal, but for now do a one-time manual update. Additionally, some deps were missing from test-requirements.in (pytest-cov, pylint). Fix them. Based on the comment in test-requirements.txt, it seems like the file wasn't properly generated from the .in file the last time it was touched.
rohanpm
force-pushed
the
rohan/pip-compile
branch
from
0062df0 to
3aee17e
Compare
rohanpm
changed the title
rbikar
approved these changes
Jun 22, 2021
chandwanitulsi
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies in CI haven't been updated in this repo for a while
because dependabot broke (unable to install rpm-py-installer).
Fixing this is a goal, but for now do a one-time manual update.
Additionally, some deps were missing from test-requirements.in
(pytest-cov, pylint). Fix them. Based on the comment in
test-requirements.txt, it seems like the file wasn't properly generated
from the .in file the last time it was touched.