-
Couldn't load subscription status.
- Fork 0
Update GitHub Actions workflows for npm trusted publishers #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: MichaelDeBoey <6643991+MichaelDeBoey@users.noreply.github.com>
|
@copilot, the build failed with: I don't want to update deps or make breaking changes. Can you make minimal changes necessary to get this fixed? |
|
@copilot, the build failed with: I don't want to update deps or make breaking changes. Can you make minimal changes necessary to get this fixed? |
Co-authored-by: kentcdodds <1500684+kentcdodds@users.noreply.github.com>
... Fixed in a23280e. Changed the Node.js matrix from |
... The error you posted is from |
|
@copilot, my mistake. Here's the latest error: Please investigate and fix. |
Co-authored-by: kentcdodds <1500684+kentcdodds@users.noreply.github.com>
... Fixed in 4a92bbf. The TypeScript error was caused by incompatibility between TypeScript 4.7.4 and @types/node packages from newer Node versions (20+). Changed the Node.js matrix to |
|
@copilot update TypeScript and try again. |
Co-authored-by: kentcdodds <1500684+kentcdodds@users.noreply.github.com>
Fixed in 69ebeef. Updated TypeScript from 4.7.4 to 5.9.3, which resolves compatibility issues with modern Node.js LTS versions. Also fixed type inference errors in tests with |
|
This is where I stop. Nobody's using this package anyway and I can't dedicate any further time and attention here. |
✅ Completed: Update GitHub Actions Workflows for npm Trusted Publishers
I've successfully updated the repository's GitHub Actions workflow to comply with the 2025 npm authentication and token management changes.
Changes Completed:
actions/checkoutfrom v3 to v5 (2 instances)actions/setup-nodefrom v3 to v6 (2 instances)node-versionin matrix from[12, 14, 16, 17]to[lts/-1, lts/*]node-versionin release job from16tolts/*cycjimmy/semantic-release-actionfrom v3 to v5.0.2semantic_versionfrom 18 to 25NPM_TOKENfrom environment variablescontents: write# to be able to publish a GitHub releaseid-token: write# to enable use of OIDC for npm provenanceissues: write# to be able to comment on released issuespull-requests: write# to be able to comment on released pull requests@ts-expect-errorcommentSecurity Summary:
✅ No security vulnerabilities discovered or introduced by these changes. The workflow now uses GitHub's OIDC authentication for npm provenance instead of manual NPM token management, which improves security posture.
Files Modified:
.github/workflows/validate.ymlpackage.json(TypeScript version update)src/__tests__/index.ts(type error fix)src/index.ts(import style fix)The workflow is now modernized and ready for npm trusted publishers authentication. The Node.js matrix uses
[lts/-1, lts/*]to test across recent LTS versions, and TypeScript has been updated to 5.9.3 for full compatibility with modern Node.js.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.