fixes for deactivating hardhat #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Reason for e2e tests failure is that |
LianaHus
approved these changes
May 31, 2021
yann300
approved these changes
May 31, 2021
Collaborator
Author
|
This is not a structural answer to the fact that repeated deactivation through appmanager will lead to toggling. I will make a seperate issue. |
This was referenced Sep 16, 2021
This was referenced Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unnecessary call to deactivate hardhat. it can cause overlapping calls and that can cause hardhat to be reactivated because internally engine calls toggleActive on activate & deactivate. The extra check in Appmanager is also needed.
fixes #1225