close files on folder close #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioedeveloper
approved these changes
Jul 21, 2021
Aniket-Engg
reviewed
Jul 21, 2021
Collaborator
Aniket-Engg
left a comment
Aniket-Engg
left a comment
There was a problem hiding this comment.
It is not closing tabs neither deleting directory from remix IDE side. It deletes it on remixd side from local fs
on reloading, folder is back locally and remixd both the side with less files
Collaborator
|
fails on: |
bunsenstraat
requested changes
Jul 22, 2021
Collaborator
bunsenstraat
left a comment
bunsenstraat
left a comment
There was a problem hiding this comment.
needs fixing, see comments
bunsenstraat
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1256
should also fix #1259