Skip to content

Conversation

@bunsenstraat
Copy link
Collaborator

@bunsenstraat bunsenstraat commented Oct 24, 2025

fix race conditions

this has to with this button reacting to compilation events

Screenshot 2025-10-27 at 08 56 59

in Desktop it would not happen because the listeners were only set when the plugin emits activation events but this event got lost if the react App component wasn't rendered yet. so having the app check if the plugin is already activated fixes that.

So test by looking at the button reacting to compilation.

@bunsenstraat bunsenstraat requested a review from joeizang October 24, 2025 07:26
@netlify
Copy link

netlify bot commented Oct 24, 2025

Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit 4439975
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/68fb2a342174d80008a1a056
😎 Deploy Preview https://deploy-preview-6492--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bunsenstraat bunsenstraat added the bug Something isn't working label Oct 24, 2025
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change set looks fine

@Aniket-Engg Aniket-Engg merged commit 6b5b1fe into master Oct 27, 2025
24 checks passed
@Aniket-Engg Aniket-Engg deleted the fix/contract-verification-plugin-activation branch October 27, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants