[fixed] injectParams invariant should not throw on values that coerce to false. #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/helpers/Path.js
Outdated
There was a problem hiding this comment.
How about != null so that null and undefined don't pass, but 0 does?
There was a problem hiding this comment.
Ah yeah, this rattled in my brain for a while, but I figured I'd get the opinion of others. 👍
There was a problem hiding this comment.
I went ahead and just amended the commit to keep it clean.
ryanflorence
added a commit
that referenced
this pull request
Jun 28, 2014
[fixed] allow 0 in path params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when I had an numeric 0 as a parameter value that an invariant messages was thrown. This is because the param value was coercing to false. This PR changes that invariant to handle those situations.