Skip to content

[fixed] injectParams invariant should not throw on values that coerce to false. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2014
Merged

[fixed] injectParams invariant should not throw on values that coerce to false. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/helpers/Path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ var Path = {
var paramName = getParamName(pathSegment);

invariant(
params[paramName],
params[paramName] != null,
'Missing "' + paramName + '" parameter for path "' + pattern + '"'
);

Expand Down
4 changes: 4 additions & 0 deletions specs/Path.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ describe('Path.injectParams', function () {
it('returns the correct path', function () {
expect(Path.injectParams(pattern, { id: 'abc' })).toEqual('comments/abc/edit');
});

it('returns the correct path when the value is 0', function () {
expect(Path.injectParams(pattern, { id: 0 })).toEqual('comments/0/edit');
});
});

describe('and some params have special URL encoding', function () {
Expand Down