fix: missing swagger errors

Author: kastov

libs/contract/constants/errors/errors.ts

@@ -1024,4 +1024,9 @@ export const ERRORS = {
         message: 'Generic reorder error',
         httpCode: 500,
     },
+    HWID_DEVICE_NOT_FOUND: {
+        code: 'A204',
+        message: 'HWID device not found',
+        httpCode: 404,
+    },
 } as const;

libs/contract/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remnawave/backend-contract",
-  "version": "2.3.19",
+  "version": "2.3.20",
   "public": true,
   "license": "AGPL-3.0-only",
   "description": "A contract library for Remnawave Backend. It can be used in backend and frontend.",

src/modules/hwid-user-devices/hwid-user-devices.controller.ts

@@ -1,5 +1,12 @@
+import {
+    ApiBearerAuth,
+    ApiNotFoundResponse,
+    ApiOkResponse,
+    ApiParam,
+    ApiQuery,
+    ApiTags,
+} from '@nestjs/swagger';
 import { Body, Controller, HttpStatus, Param, Query, UseFilters, UseGuards } from '@nestjs/common';
-import { ApiBearerAuth, ApiOkResponse, ApiParam, ApiQuery, ApiTags } from '@nestjs/swagger';
 
 import { HttpExceptionFilter } from '@common/exception/http-exception.filter';
 import { JwtDefaultGuard } from '@common/guards/jwt-guards/def-jwt-guard';
@@ -85,6 +92,9 @@ export class HwidUserDevicesController {
         };
     }
 
+    @ApiNotFoundResponse({
+        description: 'One of requested resources not found',
+    })
     @ApiOkResponse({
         type: CreateUserHwidDeviceResponseDto,
         description: 'User HWID device created successfully',
@@ -108,6 +118,9 @@ export class HwidUserDevicesController {
         };
     }
 
+    @ApiNotFoundResponse({
+        description: 'One of requested resources not found',
+    })
     @ApiOkResponse({
         type: DeleteUserHwidDeviceResponseDto,
         description: 'User HWID device deleted successfully',
@@ -134,6 +147,9 @@ export class HwidUserDevicesController {
         };
     }
 
+    @ApiNotFoundResponse({
+        description: 'One of requested resources not found',
+    })
     @ApiOkResponse({
         type: DeleteAllUserHwidDevicesResponseDto,
         description: 'User HWID devices deleted successfully',
@@ -174,6 +190,9 @@ export class HwidUserDevicesController {
         };
     }
 
+    @ApiNotFoundResponse({
+        description: 'One of requested resources not found',
+    })
     @ApiOkResponse({
         type: GetUserHwidDevicesResponseDto,
         description: 'User HWID devices fetched successfully',

src/modules/hwid-user-devices/hwid-user-devices.service.ts

@@ -196,18 +196,23 @@ export class HwidUserDevicesService {
                 userUuid,
             });
 
+            if (!hwidDevice) {
+                return {
+                    isOk: false,
+                    ...ERRORS.HWID_DEVICE_NOT_FOUND,
+                };
+            }
+
             await this.hwidUserDevicesRepository.deleteByHwidAndUserUuid(hwid, userUuid);
 
-            if (hwidDevice) {
-                this.eventEmitter.emit(
+            this.eventEmitter.emit(
+                EVENTS.USER_HWID_DEVICES.DELETED,
+                new UserHwidDeviceEvent(
+                    user.response,
+                    hwidDevice,
                     EVENTS.USER_HWID_DEVICES.DELETED,
-                    new UserHwidDeviceEvent(
-                        user.response,
-                        hwidDevice,
-                        EVENTS.USER_HWID_DEVICES.DELETED,
-                    ),
-                );
-            }
+                ),
+            );
 
             const userHwidDevices = await this.hwidUserDevicesRepository.findByCriteria({
                 userUuid,