refactor: disable catchall exception filter

Author: kastov

src/common/decorators/base-endpoint/base-endpoint.ts

@@ -56,7 +56,7 @@ export function Endpoint(options: ApiEndpointOptions) {
                 properties: {
                     message: { type: 'string' },
                     statusCode: { type: 'number', example: 400 },
-                    errors: { type: 'array', items: { type: 'object' } },
+                    error: { type: 'string' },
                 },
             },
         }),

src/common/exception/catch-all-exception-filter.ts

@@ -5,9 +5,11 @@ import {
     ArgumentsHost,
     Catch,
     ExceptionFilter,
+    ForbiddenException,
     HttpException,
     HttpStatus,
     Logger,
+    UnauthorizedException,
 } from '@nestjs/common';
 
 import { HttpExceptionWithErrorCodeType } from './http-exeception-with-error-code.type';
@@ -16,25 +18,31 @@ import { HttpExceptionWithErrorCodeType } from './http-exeception-with-error-cod
 export class CatchAllExceptionFilter implements ExceptionFilter {
     private readonly logger = new Logger(CatchAllExceptionFilter.name);
 
-    catch(exception: HttpExceptionWithErrorCodeType | ZodValidationException, host: ArgumentsHost) {
+    catch(exception: unknown, host: ArgumentsHost) {
         const ctx = host.switchToHttp();
         const response = ctx.getResponse<Response>();
         const request = ctx.getRequest<Request>();
 
         let status = HttpStatus.INTERNAL_SERVER_ERROR;
-        if (exception instanceof HttpException && exception.getStatus) {
+        if (exception instanceof HttpException) {
             status = exception.getStatus();
         }
 
-        let errorMessage: string | string[];
+        let errorMessage: string | string[] = 'Internal server error';
         let errorCode: string = 'E000';
+
         if (status === HttpStatus.FORBIDDEN) {
             errorMessage = 'Forbidden';
-        } else {
+        } else if (exception instanceof Error) {
             errorMessage = exception.message;
-            if (exception instanceof HttpExceptionWithErrorCodeType) {
-                errorCode = exception.errorCode;
-            }
+        }
+
+        if (exception instanceof HttpExceptionWithErrorCodeType) {
+            errorCode = exception.errorCode;
+        } else if (exception instanceof UnauthorizedException) {
+            errorCode = 'E401';
+        } else if (exception instanceof ForbiddenException) {
+            errorCode = 'E403';
         }
 
         if (exception instanceof ZodValidationException) {
@@ -46,22 +54,29 @@ export class CatchAllExceptionFilter implements ExceptionFilter {
             });
 
             response.status(status).json(exception.getResponse());
-        } else if (exception instanceof HttpExceptionWithErrorCodeType) {
-            response.status(status).json({
-                timestamp: new Date().toISOString(),
-                path: request.url,
-                message: errorMessage,
-                errorCode,
-            });
-        } else {
-            this.logger.error(exception);
+            return;
+        }
 
+        if (
+            exception instanceof HttpExceptionWithErrorCodeType ||
+            exception instanceof HttpException
+        ) {
             response.status(status).json({
                 timestamp: new Date().toISOString(),
                 path: request.url,
                 message: errorMessage,
                 errorCode,
             });
+            return;
         }
+
+        this.logger.error(exception);
+
+        response.status(status).json({
+            timestamp: new Date().toISOString(),
+            path: request.url,
+            message: 'Internal server error',
+            errorCode: 'E500',
+        });
     }
 }

src/main.ts

@@ -19,7 +19,6 @@ import { NestFactory } from '@nestjs/core';
 
 import { getDocs, isCrowdinEditorEnabled, isDevelopment } from '@common/utils/startup-app';
 import { proxyCheckMiddleware, getRealIp, noRobotsMiddleware } from '@common/middlewares';
-import { CatchAllExceptionFilter } from '@common/exception/catch-all-exception-filter';
 import { getStartMessage } from '@common/utils/startup-app/get-start-message';
 import { customLogFilter } from '@common/utils/filter-logs';
 import { AxiosService } from '@common/axios';
@@ -138,7 +137,7 @@ async function bootstrap(): Promise<void> {
 
     app.useGlobalPipes(new ZodValidationPipe());
 
-    app.useGlobalFilters(new CatchAllExceptionFilter());
+    // app.useGlobalFilters(new CatchAllExceptionFilter());
 
     app.enableShutdownHooks();