Skip to content

Commit 66cb32c

Browse files
authored
don't start dev server until bundle is generated (sveltejs#73)
* don't start dev server until bundle is generated (sveltejs#72) * extract `npm run start:dev` spawn into separate file
1 parent 4e3a408 commit 66cb32c

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"name": "svelte-app",
33
"version": "1.0.0",
44
"devDependencies": {
5-
"npm-run-all": "^4.1.5",
65
"rollup": "^1.12.0",
76
"rollup-plugin-commonjs": "^10.0.0",
87
"rollup-plugin-livereload": "^1.0.0",
@@ -16,8 +15,7 @@
1615
},
1716
"scripts": {
1817
"build": "rollup -c",
19-
"autobuild": "rollup -c -w",
20-
"dev": "run-p start:dev autobuild",
18+
"dev": "rollup -c -w",
2119
"start": "sirv public --single",
2220
"start:dev": "sirv public --single --dev"
2321
}

rollup.config.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import resolve from 'rollup-plugin-node-resolve';
33
import commonjs from 'rollup-plugin-commonjs';
44
import livereload from 'rollup-plugin-livereload';
55
import { terser } from 'rollup-plugin-terser';
6+
import rollup_start_dev from './rollup_start_dev';
67

78
const production = !process.env.ROLLUP_WATCH;
89

@@ -36,6 +37,10 @@ export default {
3637
}),
3738
commonjs(),
3839

40+
// In dev mode, call `npm run start:dev` once
41+
// the bundle has been generated
42+
!production && rollup_start_dev,
43+
3944
// Watch the `public` directory and refresh the
4045
// browser on changes when not in production
4146
!production && livereload('public'),

rollup_start_dev.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import * as child_process from 'child_process';
2+
3+
let running_dev_server = false;
4+
5+
export default {
6+
writeBundle() {
7+
if (!running_dev_server) {
8+
running_dev_server = true;
9+
child_process.spawn('npm', ['run', 'start:dev'], { stdio: ['ignore', 'inherit', 'inherit'] });
10+
}
11+
}
12+
};

0 commit comments

Comments
 (0)