fix: prune leftover update artifacts from the bin dir before updating#41
Merged
Conversation
The pre-1.3.2 updater extracted directly into the binary's directory and, when
it failed on Windows, could strand a partial `update-<ts>.zip` archive there.
A killed run of the current updater can likewise leave a `.rb-update-<ts>` temp
dir or a half-staged `.new` binary. None are ever reused, so they just
accumulate in the user's bin dir.
Sweep these at the start of an update: stray `update-<ts>.{zip,tar.gz}`
archives, `.rb-update-*` dirs, and `rb.new` / `rb.exe.new`. Best-effort and
wrapped in try/catch so cleanup never blocks the update. `.bak` is left alone —
it is the intentional one-version rollback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweeps stray update- archives, .rb-update-* dirs, and .new partials left by interrupted updates (notably the pre-1.3.2 Windows failure path) at the start of rb update. Best-effort; never touches .bak. Typecheck green. Also serves as the validation target for the 1.3.2 self-replace fix: lets a user on 1.3.2 update to 1.3.3 through the fixed code path.