prCreation: not-pending silently never opens PRs when CI only runs on pull_request
#44161
Unanswered
klippx
asked this question in
Request Help
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
How are you running Renovate?
Self-hosted Renovate CLI
Which platform you running Renovate on?
GitHub.com
Which version of Renovate are you using?
43.234.2
Please tell us more about your question or problem
The docs at Suppress branch/PR creation for x days recommend this combo to hold updates for a few days:
{ "minimumReleaseAge": "3 days", "internalChecksFilter": "strict", "prCreation": "not-pending" }We followed it, and PRs stopped opening. One scheduled run created/updated 30 branches but opened only 1 PR, despite
prHourlyLimit: 5andprConcurrentLimit: 10despite release age being 5+ days old for all branches.We fixed it by changing to
{ "minimumReleaseAge": "3 days", "internalChecksFilter": "strict", "prCreation": "immediate" }Which is not in line with what the instructions document on the renovate homepage.
Root cause as we understand it:
Our CI workflows trigger only on
pull_request, so a bare Renovate branch has no status checks. WithprCreation: not-pending, Renovate therefore falls back to the documented rule "if there are no checks associated, Renovate will create the PR once 24 hours have elapsed since creation of the commit."The problem is that commit creation time keeps moving: our branches get periodically re-committed (we observed all ~30 branches rewritten twice within ~2 hours), and each rewrite resets the 24h window. The result is that branches rarely survive a continuous 24h untouched, so the PRs effectively never reach the threshold. The only PR that opened belonged to a branch that happened to be 3 days old and untouched.
This is independent of
minimumReleaseAge(all target versions were 5–21 days old) and of the PR limits (only 1 PR was created).What we'd like to discuss:
not-pendingsimply the wrong tool when CI runs on PRs rather than branches? The "wait for tests" purpose can never be satisfied, so it only ever applies the 24h fallback.For our setup we've switched to
prCreation: immediateand keptminimumReleaseAge: "3 days"+internalChecksFilter: "strict", which preserves the "wait N days before the branch exists" behavior we actually wanted.Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions