Skip to content

Conversation

@ignaciosantise
Copy link
Collaborator

Summary

  • added react-native-mmkv for storage

Copilot AI review requested due to automatic review settings October 13, 2025 18:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces AsyncStorage with react-native-mmkv for storage operations in the React Native wallet application. MMKV provides better performance and synchronous operations compared to AsyncStorage's asynchronous API.

Key changes:

  • Added react-native-mmkv dependency and created a storage utility wrapper
  • Replaced all AsyncStorage imports and usage with the new storage utility
  • Updated iOS project configuration and removed unnecessary Xcode project entries

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/utils/storage.ts New storage utility wrapper providing async API over MMKV
src/utils/WalletKitUtil.ts Updated to use new storage utility instead of AsyncStorage
src/utils/SuiWalletUtil.ts Replaced AsyncStorage with storage utility for mnemonic operations
src/utils/EIP155WalletUtil.ts Updated wallet initialization to use new storage utility
src/store/SettingsStore.ts Migrated settings storage from AsyncStorage to new utility
src/screens/Settings/index.tsx Updated settings screen to use new storage utility
package.json Added react-native-mmkv dependency
ios/RNWeb3Wallet.xcodeproj/project.pbxproj Cleaned up Xcode project configuration
ios/.xcode.env Updated Xcode environment configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ignaciosantise ignaciosantise changed the title chore: mmkv chore: use mmkv as storage in wallet sample Oct 13, 2025
@ignaciosantise ignaciosantise merged commit 5d9ce23 into main Oct 13, 2025
6 checks passed
@ignaciosantise ignaciosantise deleted the chore/add-mmkv branch October 13, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants