chore: nfc capabilities #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds NFC (Near Field Communication) support to both the React Native wallet app and the POS dapp, enabling these applications to read NFC tags for sending messages.
- Adds NFC permissions and entitlements for both iOS and Android platforms
- Adds user-facing usage descriptions for iOS NFC access
- Bumps the Android version code for the POS app
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wallets/rn_cli_wallet/ios/RNWeb3Wallet/RNWeb3WalletDebug.entitlements | Adds NFC TAG reader session format entitlement for debug builds |
| wallets/rn_cli_wallet/ios/RNWeb3Wallet/RNWeb3Wallet.entitlements | Adds NFC TAG reader session format entitlement for release builds |
| wallets/rn_cli_wallet/ios/RNWeb3Wallet/Internal-Info.plist | Adds NFC usage description for internal builds |
| wallets/rn_cli_wallet/ios/RNWeb3Wallet/Info.plist | Adds NFC usage description for standard builds |
| wallets/rn_cli_wallet/ios/RNWeb3Wallet/Debug-Info.plist | Adds NFC usage description for debug builds |
| wallets/rn_cli_wallet/android/app/src/main/AndroidManifest.xml | Adds NFC permission for Android wallet app |
| dapps/pos-app/ios/mobilepos/mobilepos.entitlements | Adds NFC TAG reader session format entitlement |
| dapps/pos-app/ios/mobilepos/Info.plist | Adds NFC usage description |
| dapps/pos-app/ios/mobilepos.xcodeproj/project.pbxproj | Reorders resource references and removes unnecessary quotes in build settings |
| dapps/pos-app/app.json | Configures NFC permissions and usage description in Expo config |
| dapps/pos-app/android/app/src/main/AndroidManifest.xml | Adds NFC permission for Android POS app |
| dapps/pos-app/android/app/build.gradle | Increments version code from 1 to 2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added nfc capabilities config to wallet and pos app. Just the permissions