fix(rpc): allow default deserialization value for subscription data tag #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
force-pushed
the
fix/allow-default-value-for-tag-in-subscription-data
branch
from
9c2dcc1 to
1f4b0f2
Compare
Rakowskiii
approved these changes
Mar 2, 2023
farazdagi
deleted the
fix/allow-default-value-for-tag-in-subscription-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #6
Just as an extra pre-caution, let's mark the newly introduced field with
default, allowing some previously saved JSON data (say persisted in mailbox, previously, so notagvalue set) be deserialized into the subscription data that has this newtagfield introduced.Otherwise, we will have issues deserealizing previously persisted data.
How Has This Been Tested?
Due Diligence