Skip to content

chore: move sidebar icons to only root level #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2024
Merged

chore: move sidebar icons to only root level #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443e2ae
chore: move sidebar icons to only root level
crutchcorn Apr 29, 2024
f02f196
Merge branch 'main' into change-sidebar-icons
crutchcorn May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/Navigation.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
display: flex;
width: 100%;
align-items: center;
justify-content: space-between;
border-radius: 0.375rem;
text-align: left;
line-height: 1.5;
Expand Down
23 changes: 15 additions & 8 deletions src/components/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,9 @@ function ItemLink({
onClick={item.href ? onLinkClick : undefined}
className={clsx(styles.item, className, isSelected && styles.selected)}
>
<NavIcon
icon={item.icon}
aria-hidden="true"
className="ml-1 fill-inherit stroke-inherit text-inherit"
/>
{item.title}
<span className="ml-6">
{item.title}
</span>
</Link>
)
}
Expand All @@ -59,12 +56,17 @@ export function Navigation({
<Link
href="/quickstart"
className={clsx(
'flex w-full items-center justify-between rounded-md pb-1 text-left leading-6',
'flex w-full items-center rounded-md pb-1 text-left leading-6',
pathname.includes('/quickstart')
? 'text-sky-500'
: 'hover:text-gray-900 dark:hover:text-gray-300',
)}
>
<NavIcon
icon={"home"}
aria-hidden="true"
className="ml-1 fill-inherit stroke-inherit text-inherit"
/>
Quickstart Guide
</Link>
{navigation.map((section) => {
Expand All @@ -84,14 +86,19 @@ export function Navigation({
section.href !== '' && pathname.includes(section.href),
)}
>
<NavIcon
icon={section.icon}
aria-hidden="true"
className="ml-1 fill-inherit stroke-inherit text-inherit"
/>
{section.title}
<Icon
icon="chevron"
className={clsx(
open
? 'rotate-90 '
: 'text-gray-600 dark:text-gray-400',
'w-5 shrink-0',
'ml-auto w-5 shrink-0',
pathname.includes(section.href) &&
'text-gray-900 dark:text-gray-200',
)}
Expand Down
Loading