Add support for build secrets #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/secrets
branch
2 times, most recently
from
494b8ef to
3406011
Compare
mattt
commented
Apr 25, 2023
mattt
force-pushed
the
mattt/secrets
branch
3 times, most recently
from
3312023 to
b5d244e
Compare
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
evilstreak
reviewed
Apr 25, 2023
| PythonVersion string `json:"python_version,omitempty" yaml:"python_version"` | ||
| PythonRequirements string `json:"python_requirements,omitempty" yaml:"python_requirements"` | ||
| PythonPackages []string `json:"python_packages,omitempty" yaml:"python_packages"` // Deprecated, but included for backwards compatibility | ||
| Run []RunItem `json:"run,omitempty" yaml:"run"` |
Contributor
There was a problem hiding this comment.
Does this require an update to the run docs given the change in syntax? Do we want to continue to support the old syntax as well?
Contributor
Author
There was a problem hiding this comment.
Good callout. I just added docs with 080e0fa.
This new format is an additive change, so existing uses of run commands will continuing working. I don't have any plans to deprecate the old syntax.
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
mattt
added a commit
that referenced
this pull request
May 31, 2024
* Add support for run commands with mounted secrets Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Document new run item format Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1009