Skip to content

Fix regression in cog predict #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2023
Merged

Fix regression in cog predict #1029

merged 2 commits into from
May 5, 2023

Conversation

@mattt
Copy link
Contributor

@mattt mattt commented May 5, 2023

Fixes #1028

$ cog predict r8.im/daanelson/stable-diffusion-speed-lab@sha256:db21e45d3f7023abc2a46ee38a23973f6dce16bb082a930b0c49861f96d1e5bf -i prompt=guitar
ⅹ Failed to parse config from r8.im/daanelson/stable-diffusion-speed-lab@sha256:db21e45d3f7023abc2a46ee38a23973f6dce16bb082a930b0c49861f96d1e5bf: json: cannot unmarshal string into Go struct field Build.build.run of type config.RunItem

This PR adds the missing UnmarshallJSON method causing this error.

mattt added 2 commits May 5, 2023 10:58
@mattt
Implement UnmarshalJSON method for RunItem
3de8c3d 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt
Add tests for RunItem decoding
87c1df6 
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt mattt requested a review from andreasjansson May 5, 2023 18:00
@mattt mattt enabled auto-merge (squash) May 5, 2023 18:01
@mattt mattt merged commit 642f550 into main May 5, 2023
@mattt mattt deleted the mattt/fix-cog-predict-runitem branch May 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreasjansson andreasjansson Awaiting requested review from andreasjansson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cog predict error when unmarshaling run item from cog.yaml

2 participants

@mattt