Small fix: don't install python when using python base image #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: technillogue <technillogue@gmail.com>
nickstenning
approved these changes
Jul 25, 2023
mattt
added a commit
that referenced
this pull request
Sep 8, 2023
commit 12b79d553f3885aab6f140ddc9c7099a2a0ffd40
Author: technillogue <technillogue@gmail.com>
Date: Tue Sep 5 19:16:40 2023 -0400
COG_EXPERIMENTAL_BUILD_STAGE_DEPS for dependencies required in the pip install stage (#1289)
* REPLICATE_EXPERIMENTAL_BUILD_STAGE_DEPS
Signed-off-by: technillogue <technillogue@gmail.com>
* call it COG
Signed-off-by: technillogue <technillogue@gmail.com>
* fmt
Signed-off-by: technillogue <technillogue@gmail.com>
---------
Signed-off-by: technillogue <technillogue@gmail.com>
commit caba7fdf513f058cf64282e486b02d1b78ed7337
Author: technillogue <technillogue@gmail.com>
Date: Tue Sep 5 18:55:30 2023 -0400
Multistage pip install (#1233)
* initial draft
Signed-off-by: technillogue <technillogue@gmail.com>
* move install cog before install user deps
Signed-off-by: technillogue <technillogue@gmail.com>
* fix tests
Signed-off-by: technillogue <technillogue@gmail.com>
* try different copy dest to fix integration tests
Signed-off-by: technillogue <technillogue@gmail.com>
* fix tests
Signed-off-by: technillogue <technillogue@gmail.com>
* note why test is broken
Signed-off-by: technillogue <technillogue@gmail.com>
* try to determine the actual location of site-packages in the final image
Signed-off-by: technillogue <technillogue@gmail.com>
* check if a different version would pass the tests
Signed-off-by: technillogue <technillogue@gmail.com>
* also update go tests
Signed-off-by: technillogue <technillogue@gmail.com>
* clean comments
Signed-off-by: technillogue <technillogue@gmail.com>
* notes about resolving minor versions for pyenv
Signed-off-by: technillogue <technillogue@gmail.com>
* fmt
Signed-off-by: technillogue <technillogue@gmail.com>
* try using copying dependencies to a known place, then symlink to whereever pyenv actually is
Signed-off-by: technillogue <technillogue@gmail.com>
* remove dead code
Signed-off-by: technillogue <technillogue@gmail.com>
* reword comment
Signed-off-by: technillogue <technillogue@gmail.com>
---------
Signed-off-by: technillogue <technillogue@gmail.com>
commit d65f2c8fa68f89a36cfb3eb2f3bc491e7c07365e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Sep 5 03:23:57 2023 -0700
Bump golang.org/x/sys from 0.11.0 to 0.12.0 (#1287)
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.11.0 to 0.12.0.
- [Commits](https://github.com/golang/sys/compare/v0.11.0...v0.12.0)
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit ef8d08b1bef26eeb237de394fba31da43715c2c2
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Sep 5 03:23:42 2023 -0700
Bump github.com/getkin/kin-openapi from 0.118.0 to 0.119.0 (#1286)
Bumps [github.com/getkin/kin-openapi](https://github.com/getkin/kin-openapi) from 0.118.0 to 0.119.0.
- [Release notes](https://github.com/getkin/kin-openapi/releases)
- [Commits](https://github.com/getkin/kin-openapi/compare/v0.118.0...v0.119.0)
---
updated-dependencies:
- dependency-name: github.com/getkin/kin-openapi
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 8b2a881acf81df2774868fa160d6adc4e58aac2a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Sep 5 03:21:51 2023 -0700
Bump actions/checkout from 3 to 4 (#1285)
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 1b8c5c72b25e3ab0aa2c9c6b8ce4546bfa44b475
Author: Zeke Sikelianos <zeke@sikelianos.com>
Date: Tue Aug 29 10:34:47 2023 -0700
add TOC and fix heading levels
commit e50bfc8a3ee7c077a90c52a80b1444b9c2c6181a
Author: Zeke Sikelianos <zeke@sikelianos.com>
Date: Tue Aug 29 10:34:34 2023 -0700
document stopping the server
commit b6dcbf410f5f71ec2e9aa989b727e3413a2adfbf
Author: Zeke Sikelianos <zeke@sikelianos.com>
Date: Tue Aug 29 10:01:26 2023 -0700
fix typos
commit a51ac8c2b490a854cd2340589f235403cde18f14
Author: Zeke Sikelianos <zeke@sikelianos.com>
Date: Tue Aug 29 10:01:20 2023 -0700
document running a server to view OpenAPI schema
commit 0a33f6e5669b5c543913e89acb4e9bff8ef1dda5
Author: Zeke Sikelianos <zeke@sikelianos.com>
Date: Tue Aug 29 10:10:00 2023 -0700
update pip install command in contributing guide
commit 5390bf1643d6c93e04a529e312c1b7a7c7edb7fc
Author: Zeke Sikelianos <zeke@sikelianos.com>
Date: Tue Aug 29 08:29:31 2023 -0700
Update docs/training.md
Co-authored-by: Dominic Baggott <dominic.baggott@gmail.com>
Signed-off-by: Zeke Sikelianos <zeke@sikelianos.com>
commit 66221b01493b77617280dbb1b6e70bb7236c9412
Author: Zeke Sikelianos <zeke@sikelianos.com>
Date: Mon Aug 28 15:55:40 2023 -0700
document training API
commit ecf2ad26cd8b4c1624b9d8cffabf236d8dc7c9b3
Author: Jesse Andrews <jesse@replicate.com>
Date: Wed Aug 9 22:16:41 2023 +0000
support -e for cog run
Signed-off-by: Jesse Andrews <jesse@replicate.com>
commit 7a9f2da66873aeb5cc18f854e923c180c54d1318
Author: Jesse Andrews <jesse@replicate.com>
Date: Wed Aug 9 22:14:28 2023 +0000
support for -e in cog predict
Signed-off-by: Jesse Andrews <jesse@replicate.com>
commit a6a26b7f7a26bec45c92a8644fed3c454099dd39
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Aug 21 12:32:11 2023 -0700
Bump github.com/golangci/golangci-lint from 1.54.1 to 1.54.2 (#1268)
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.54.1 to 1.54.2.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.54.1...v1.54.2)
---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 243d2044326be713385204677811c1a0609556d9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Aug 16 03:12:06 2023 -0700
Bump github.com/golangci/golangci-lint from 1.53.3 to 1.54.1 (#1260)
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.53.3 to 1.54.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.53.3...v1.54.1)
---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 6e2bba7653bf7bcd95cf3af35f422536aeb87d2d
Author: technillogue <technillogue@gmail.com>
Date: Mon Aug 7 17:41:39 2023 -0400
parse type signature without running container (#1155)
* parse type signature from AST, without docker run
Signed-off-by: technillogue <technillogue@gmail.com>
* quote complex types for older python versions
Signed-off-by: technillogue <technillogue@gmail.com>
* add to tests and start fixing revealed problems
Signed-off-by: technillogue <technillogue@gmail.com>
* handle defaults more carefully and some other fixes
Signed-off-by: technillogue <technillogue@gmail.com>
* parse output type
Signed-off-by: technillogue <technillogue@gmail.com>
* add remaining test cases and make them pass
Signed-off-by: technillogue <technillogue@gmail.com>
* move static schema behind a flag
Signed-off-by: technillogue <technillogue@gmail.com>
* fix for py3.8
Signed-off-by: technillogue <technillogue@gmail.com>
* another fix for py3.8
Signed-off-by: technillogue <technillogue@gmail.com>
* more fixes for py3.7 AST
Signed-off-by: technillogue <technillogue@gmail.com>
* even more py3.7 fixes
Signed-off-by: technillogue <technillogue@gmail.com>
* Instead of the static-schema flag, just accept an openapi-schema flag
Signed-off-by: technillogue <technillogue@gmail.com>
* Write generated schema to a file
Signed-off-by: technillogue <technillogue@gmail.com>
* Remove debugging changes
Signed-off-by: technillogue <technillogue@gmail.com>
* fix gocritic
Signed-off-by: technillogue <technillogue@gmail.com>
* Formatting
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix linting warnings in types.py
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Log OpenAPI spec when validation fails
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix check for adding Cog labels
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Apply suggestions from code review
Signed-off-by: Mattt <mattt@me.com>
---------
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Signed-off-by: Mattt <mattt@me.com>
Co-authored-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Mattt <mattt@me.com>
commit 8deb0ae9c2e756938711eadf682f4a3cd7f1dea3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Aug 7 13:02:22 2023 -0700
Bump golang.org/x/tools from 0.11.1 to 0.12.0 (#1249)
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.11.1 to 0.12.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/compare/v0.11.1...v0.12.0)
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 2b4515b3635c4d1a8ca5d8f94c2e390e383b96d4
Author: Iskren Ivov Chernev <me@iskren.info>
Date: Wed Aug 2 01:29:37 2023 +0300
Fix weights-manifest change check (#1239)
The weights are changed if there is no cache (no previous value) or the
value differs.
Signed-off-by: Iskren Chernev <me@iskren.info>
commit 66bdfb3e3a18036899822feb72c8cc30d7aeab72
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Jul 31 14:33:15 2023 -0700
Bump golang.org/x/tools from 0.11.0 to 0.11.1 (#1240)
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.11.0 to 0.11.1.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/compare/v0.11.0...v0.11.1)
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 64bf0121c25b11a21f35c78fd76d5968c0b2dc9c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Jul 31 11:45:28 2023 +0000
Bump actions/setup-python from 3 to 4 (#1237)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3 to 4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v3...v4)
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit fa3992eebab24aae01a286c25a8fe62058d44d3f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Jul 31 11:45:17 2023 +0000
Bump goreleaser/goreleaser-action from 2 to 4 (#1238)
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 2 to 4.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](https://github.com/goreleaser/goreleaser-action/compare/v2...v4)
---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 00406cf1fd24e3ad3307aad904f85490a1ef322d
Author: Mattt <mattt@replicate.com>
Date: Mon Jul 31 04:36:14 2023 -0700
Update dependabot.yml (#1236)
Add github-actions package ecosystem
Signed-off-by: Mattt <mattt@replicate.com>
commit 27ff16834b27aaa20a8447343a11db1649afbca6
Author: Nick Stenning <nick@whiteink.com>
Date: Mon Jul 31 12:16:54 2023 +0200
Validate model schema on build (#1232)
commit 02c4a3e1c6c1de52a680f7c2d9f8bf58f7f82979
Author: Hongchao Deng <hongchaodeng1@gmail.com>
Date: Fri Jul 28 05:38:16 2023 +0800
feat: skip building the weights image to speed up (#1223)
* feat: skip building the weights image to speed up
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
* Encode CRC32 checksums as hexadecimal instead of base64
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Rename Hash to Manifest and refactor implementation
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove comments for self-explanatory code
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Mattt Zmuda <mattt@replicate.com>
commit 22dfa5a9e0db30d987727f511db932b70089ee99
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Thu Jul 27 12:55:40 2023 +0000
Bump github.com/docker/cli (#1226)
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 24.0.4+incompatible to 24.0.5+incompatible.
- [Commits](https://github.com/docker/cli/compare/v24.0.4...v24.0.5)
---
updated-dependencies:
- dependency-name: github.com/docker/cli
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 59bc5fb4388017900113910dd6c36c53afc8ca01
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Thu Jul 27 05:45:27 2023 -0700
Bump github.com/docker/docker (#1227)
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.4+incompatible to 24.0.5+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](https://github.com/docker/docker/compare/v24.0.4...v24.0.5)
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 1ae1ca541a1f3254522fd236b3882272ec6349a6
Author: Mattt <mattt@replicate.com>
Date: Wed Jul 26 06:20:38 2023 -0700
Revert "Download `tini` in separate stage (#1161)" (#1231)
This reverts commit 2e331c79cc7867af881363fe7aae72db31ca617a.
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 218bdf2846eedca44590cd1a4fdd9abde23d25a1
Author: technillogue <technillogue@gmail.com>
Date: Tue Jul 25 18:10:33 2023 -0400
Small fix: don't install python when using python base image (#1230)
Signed-off-by: technillogue <technillogue@gmail.com>
commit cb5b9bc9d0424e250af78e9b6d47438372d45afe
Author: Mattt <mattt@replicate.com>
Date: Fri Jul 21 09:35:39 2023 -0700
Add `--use-cuda-base-image` flag (#1214)
* initial draft
* fix some tests
* set flag to be true by default and add it to the config schema
Signed-off-by: technillogue <technillogue@gmail.com>
* Sketch out --use-cuda-base-image as CLI flag
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Make --use-cuda-base-image a string flag with true/false
* fix strange failing test with incorrect default output filename
* Try revertting "fix strange failing test with incorrect default output filename"
* in python:3.8-slim, but not python:3.8, mimetypes.guess_type reports .bmp as image/x-ms-bmp instead of image/bmp
* fmt
Signed-off-by: technillogue <technillogue@gmail.com>
---------
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: technillogue <technillogue@gmail.com>
commit 220b68ab09fe0a7519bf5d47889403a2733de93d
Author: Mattt <mattt@replicate.com>
Date: Mon Jul 17 07:06:25 2023 -0700
Configure goimports local prefix (#1213)
* Configure local prefix for goimports
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Reorder imports using goimports with local option
go run golang.org/x/tools/cmd/goimports -w -local github.com/replicate/cog .
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove gci linter and configuration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit abea92bd2af76278b2df5c35c3267c35246666d1
Author: Mattt <mattt@replicate.com>
Date: Mon Jul 17 06:58:56 2023 -0700
Remove exception for 'compatability' in misspell configuration (#1212)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit d9387427b2f8f523ffc09cacbdc69034479e40f7
Author: Mattt Zmuda <mattt@replicate.com>
Date: Mon Jul 17 05:11:10 2023 -0700
Fix typo 'compatability'
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 805c354ac8b5e644ffc7add0d7aebdd85c11a473
Author: Mattt <mattt@replicate.com>
Date: Mon Jul 17 05:01:52 2023 -0700
Update Go linter configuration (#1210)
* Formatting
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Replace deadcode with unused
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Replace varcheck with unused
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix var-declaration linter violation
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix if-return linter violations
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix formatting of top-level rules
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Disable unused-parameter rule in revive
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Replace structcheck with unused
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Replace golint with revive
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove unused linters
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Replace unparam with unused
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove lll configuration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove unparam configuration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Unset issues.exclude option
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Temporarily comment out goimports configuration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove gosimple
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove unused maligned configuration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove unused golint configuration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove unused severity in unused-parameter rule setting
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Replace goimports with gci
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Enable gosec linter
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 1aaafe1ba80846447accd1501a94a61fe282270e
Author: technillogue <technillogue@gmail.com>
Date: Wed Jul 12 15:40:19 2023 -0400
don't import numpy at the top of json.py (#1203)
* don't import numpy at the top of json.py
Signed-off-by: technillogue <technillogue@gmail.com>
* move down to when numpy is actually used
Signed-off-by: technillogue <technillogue@gmail.com>
---------
Signed-off-by: technillogue <technillogue@gmail.com>
commit 01fad8257c7dd8c0a596e1c7ab4588177d50e92d
Author: 江湖十年 <jianghushinian007@163.com>
Date: Wed Jul 12 01:17:10 2023 +0800
fix(python): put file to endpoint `file.seek(0)` (#990)
Signed-off-by: 江湖十年 <jianghushinian007@163.com>
commit 5186e251e7d5be897d470166e608608587abbfab
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 16:55:11 2023 +0200
Use --clean instead of --rm-dist
https://goreleaser.com/deprecations/#-rm-dist
commit 1a4922e606ac0504761fd28e2a9eda6bc9670618
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 16:12:25 2023 +0200
Python 3.7 compat: don't use missing_ok kwarg
This was added in Python 3.8.
Signed-off-by: Nick Stenning <nick@whiteink.com>
commit 340e76fadd98735ed0b80ecffa226fa295956746
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 15:23:58 2023 +0200
Pin fastapi to <0.99
0.99 introduces OpenAPI 3.1.0 for which the tests will need updating.
Signed-off-by: Nick Stenning <nick@whiteink.com>
commit c090b577193fec1dfef541b3671a9e34a23395bf
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 15:21:00 2023 +0200
Python 3.7 compat: add typing-compat for get_{args,origin}
Signed-off-by: Nick Stenning <nick@whiteink.com>
commit 97d546b269166d0c8ebe05352af09350531c6790
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 15:15:47 2023 +0200
Unpin dev dependencies, too
There is no pinned set of dev dependencies which works for all Python
versions from 3.7 to 3.11. Let each Python version resolve its own dev
dependencies.
If we need tighter requirements we should specify those in
pyproject.toml directly.
Signed-off-by: Nick Stenning <nick@whiteink.com>
commit 7274e9fd73eb4029eaf4acf5ff4c2eef403aa680
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 14:37:41 2023 +0200
Unpin library deps
It doesn't seem wise to pin our primary dependencies, as the consumers
of the `cog` package will not have them pinned, and the exact versions
selected by `pip` will depend on the version of Python under which the
installation occurs as well as any other platform or environmental
version selectors specified by our dependencies.
This unpins the library dependencies so we're testing Cog in the same
environment that it will be used.
Signed-off-by: Nick Stenning <nick@whiteink.com>
commit 0fbd1c423328d51f61449f72ab0d2b7daec0f59e
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 14:13:14 2023 +0200
Add support for Python 3.7 again
Signed-off-by: Nick Stenning <nick@whiteink.com>
commit 45f459be0ca739b5b99b40c6577c94697beb35f7
Author: Nick Stenning <nick@whiteink.com>
Date: Tue Jul 11 16:30:51 2023 +0200
Don't run test_build_gpu_model_on_cpu locally
This test overwrites global git config, which is not safe to do locally.
For now, just skip the test unless in the CI environment.
commit 83ad769f078c3aef3c7fc9dda62a7694546d206d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 09:12:27 2023 +0000
Bump golang.org/x/tools from 0.10.0 to 0.11.0 (#1195)
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.10.0 to 0.11.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/compare/v0.10.0...v0.11.0)
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit ee4eae7df188478054a6269a5948f9c0f40aba2f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 09:12:02 2023 +0000
Bump github.com/docker/cli (#1198)
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 24.0.2+incompatible to 24.0.4+incompatible.
- [Commits](https://github.com/docker/cli/compare/v24.0.2...v24.0.4)
---
updated-dependencies:
- dependency-name: github.com/docker/cli
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit db2c3b05efb585a166dff3e3a7e65c50bfd7a129
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 02:03:51 2023 -0700
Bump httptools from 0.5.0 to 0.6.0 (#1192)
Bumps [httptools](https://github.com/MagicStack/httptools) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/MagicStack/httptools/releases)
- [Commits](https://github.com/MagicStack/httptools/compare/v0.5.0...v0.6.0)
---
updated-dependencies:
- dependency-name: httptools
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit b36cd3e80757a778ca04c59bf267e941076131fa
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 02:03:37 2023 -0700
Bump platformdirs from 3.5.1 to 3.8.1 (#1193)
Bumps [platformdirs](https://github.com/platformdirs/platformdirs) from 3.5.1 to 3.8.1.
- [Release notes](https://github.com/platformdirs/platformdirs/releases)
- [Changelog](https://github.com/platformdirs/platformdirs/blob/main/CHANGES.rst)
- [Commits](https://github.com/platformdirs/platformdirs/compare/3.5.1...3.8.1)
---
updated-dependencies:
- dependency-name: platformdirs
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit db86adf87c3f02d766b1582c9c7d502f0fb4c5a7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 02:03:28 2023 -0700
Bump execnet from 1.9.0 to 2.0.2 (#1194)
Bumps [execnet](https://github.com/pytest-dev/execnet) from 1.9.0 to 2.0.2.
- [Changelog](https://github.com/pytest-dev/execnet/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/execnet/compare/v1.9.0...v2.0.2)
---
updated-dependencies:
- dependency-name: execnet
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 8fe24c1eef892e0cd2fc25c8ec47db45511a7a5e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 02:03:08 2023 -0700
Bump gotest.tools/gotestsum from 1.10.0 to 1.10.1 (#1196)
Bumps [gotest.tools/gotestsum](https://github.com/gotestyourself/gotestsum) from 1.10.0 to 1.10.1.
- [Release notes](https://github.com/gotestyourself/gotestsum/releases)
- [Commits](https://github.com/gotestyourself/gotestsum/compare/v1.10.0...v1.10.1)
---
updated-dependencies:
- dependency-name: gotest.tools/gotestsum
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 6bbddcf698b4ae11cb546ac3cfc2db6da8e048fd
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 02:03:00 2023 -0700
Bump github.com/docker/docker (#1197)
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.2+incompatible to 24.0.4+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](https://github.com/docker/docker/compare/v24.0.2...v24.0.4)
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 350f4dd04ab4925492ac02e1ba38fbf1861ffb23
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jul 11 02:02:39 2023 -0700
Bump golang.org/x/sys from 0.9.0 to 0.10.0 (#1199)
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.9.0 to 0.10.0.
- [Commits](https://github.com/golang/sys/compare/v0.9.0...v0.10.0)
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 5e3fe5b09da709768293d81cee085293ce448a3c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sat Jul 8 04:28:50 2023 -0700
Bump pillow from 9.5.0 to 10.0.0 (#1165)
Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.5.0 to 10.0.0.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](https://github.com/python-pillow/Pillow/compare/9.5.0...10.0.0)
---
updated-dependencies:
- dependency-name: pillow
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit a324cf719ec6608376f7238a42f83b1d93476eee
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sat Jul 8 04:28:32 2023 -0700
Bump typing-extensions from 4.6.3 to 4.7.1 (#1166)
Bumps [typing-extensions](https://github.com/python/typing_extensions) from 4.6.3 to 4.7.1.
- [Release notes](https://github.com/python/typing_extensions/releases)
- [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md)
- [Commits](https://github.com/python/typing_extensions/compare/4.6.3...4.7.1)
---
updated-dependencies:
- dependency-name: typing-extensions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 56a03531aff5202f388f69c451d460e182f46703
Author: Mattt <mattt@replicate.com>
Date: Fri Jul 7 11:52:52 2023 -0700
Exclude Makefile from GitHub repository statistics (#1183)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 263835379c87178ec341db951e3d31e7d722d0ca
Author: Mattt <mattt@replicate.com>
Date: Fri Jul 7 11:38:12 2023 -0700
Accumulate errors in `ValidateAndComplete` (#1174)
* Update to Go 1.20
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Accumulate errors in ValidateAndComplete
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 3752d7a5c776729ecbea9f390719baf04dd4e8bb
Author: Mattt <mattt@replicate.com>
Date: Fri Jul 7 11:37:55 2023 -0700
Upgrade to Go 1.20 (#1177)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 3915acc11467439e56cd11a14372938ca2ee11d9
Author: Nick Stenning <nick@whiteink.com>
Date: Fri Jul 7 15:47:42 2023 +0200
Fix input filename handling issues (#1181)
We have a bunch of issues with input filename handling. The most
important is that we set no limits on filename length, which results in
errors when the filename exceeds Linux's 255 byte limit.
This commit does the following:
- enforces a shorter 200-byte filename limit through truncation
- correctly decodes URL-encoded filenames
- protects against illegal characters in filenames (nul byte, slash)
In addition, it replaces a couple of ad-hoc data URI parsers with use of
`urllib.request.urlopen`, which has supported data URIs since Python
3.4.
Signed-off-by: Nick Stenning <nick@whiteink.com>
commit 2e331c79cc7867af881363fe7aae72db31ca617a
Author: Mattt <mattt@replicate.com>
Date: Tue Jul 4 07:54:58 2023 -0700
Download `tini` in separate stage (#1161)
* Download tini in separate stage
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Use appropriate/curl because it's smaller
Signed-off-by: technillogue <technillogue@gmail.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Co-authored-by: technillogue <technillogue@gmail.com>
commit a7a1e4cb09a7a9cfeca10ebeb5f69d77e3fd87be
Author: Mattt <mattt@replicate.com>
Date: Tue Jul 4 07:45:14 2023 -0700
Inline replacements rules into name_template (#1176)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 67d35b23674b608961b680ddfa8b3a6de6f7abd2
Author: Mattt <mattt@replicate.com>
Date: Tue Jul 4 06:50:48 2023 -0700
Allow `MAJOR.MINOR` to match `MAJOR.MINOR.PATCH` with non-zero patch (#1175)
* Add build.cuDNN property to cog.yaml schema
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Allow MAJOR.MINOR to match MAJOR.MINOR.PATCH with non-zero patch
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix test expectations
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Re-enable TestValidateAndCompleteCUDAForAllTorch
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit c473c9e2ff74d9887db776d45db586e72b759205
Author: Mattt <mattt@replicate.com>
Date: Tue Jul 4 04:13:43 2023 -0700
Refactor compatibility generation (#1170)
* Update CUDA base images
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Refactor compatibility generation
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* use newer cuda in tests
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Update tests for new CUDA image availability
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Zeke Sikelianos <zeke@sikelianos.com>
commit 96c556fc05f651d85d6dcba489f838209115e892
Author: Hongchao Deng <hongchaodeng1@gmail.com>
Date: Tue Jul 4 18:08:39 2023 +0800
fix: debug cmd should have --separate-weights (#1173)
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
commit 67f607c6c7b7d0b0916b7bc1834b3199b18ff307
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 28 12:26:14 2023 -0700
Bump github.com/getkin/kin-openapi from 0.110.0 to 0.118.0 (#1072)
Bumps [github.com/getkin/kin-openapi](https://github.com/getkin/kin-openapi) from 0.110.0 to 0.118.0.
- [Release notes](https://github.com/getkin/kin-openapi/releases)
- [Commits](https://github.com/getkin/kin-openapi/compare/v0.110.0...v0.118.0)
---
updated-dependencies:
- dependency-name: github.com/getkin/kin-openapi
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit b3a03099ecf5316cc4e9bc62c00676a835503943
Author: Mattt Zmuda <mattt@replicate.com>
Date: Wed Jun 28 12:22:16 2023 -0700
Update README
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit bfdb0ca19d17f3415037336308642c758dc16d49
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 28 12:16:50 2023 -0700
Conditionally prepend cog- to default image name (#1148)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 942b5d8148b3799f00b72bf329788b573fdb18fa
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 28 12:16:14 2023 -0700
Don't use first input as implicit input name in `cog predict` (#1154)
* Don't use first input as implicit input name
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Update predict tests to use named inputs
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit b0cc80f27f7972e43eeea2917506e9b302e3fd9e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 28 06:03:12 2023 -0700
Bump fastapi from 0.97.0 to 0.98.0 (#1145)
Bumps [fastapi](https://github.com/tiangolo/fastapi) from 0.97.0 to 0.98.0.
- [Release notes](https://github.com/tiangolo/fastapi/releases)
- [Commits](https://github.com/tiangolo/fastapi/compare/0.97.0...0.98.0)
---
updated-dependencies:
- dependency-name: fastapi
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 04445259342b7f1fdbb0b0ae4efaeb7eb7bcb347
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 28 06:03:01 2023 -0700
Bump hypothesis from 6.79.2 to 6.80.0 (#1150)
Bumps [hypothesis](https://github.com/HypothesisWorks/hypothesis) from 6.79.2 to 6.80.0.
- [Release notes](https://github.com/HypothesisWorks/hypothesis/releases)
- [Commits](https://github.com/HypothesisWorks/hypothesis/compare/hypothesis-python-6.79.2...hypothesis-python-6.80.0)
---
updated-dependencies:
- dependency-name: hypothesis
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 8d31da919409531c102ce1c26c080020d72fbc05
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 28 05:51:16 2023 -0700
Rerun flaky integration tests (#1152)
* Add pytest-rerunfailures dev dependency
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Run test-integration with --reruns 5
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Remove unused redis dependency in test-integration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit cc72a694096691845c945ccfe0858a61d12d608b
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 28 05:46:05 2023 -0700
Make separate weights feature opt-in (#1151)
* Rename --no-weights-image to --separate-weights
Make separate weights opt-in
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Refactor debug command
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Update note about separate weights in Getting Started
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 0ced8d72e15bb3896643b58b1cb9d2118ca0d1ad
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 28 04:56:16 2023 -0700
Add `.dockerignore` file to `cog init` template (#1136)
* Add .dockerignore to cog init template
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Refactor initCommand to remove duplicated code
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Update default .dockerignore file
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 0b09c4c2007a4c2210a66c3847030e4f96601989
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 28 04:45:50 2023 -0700
Configure Dependabot to run weekly (#1149)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 078c66abd9587f555258292581041d7998fe1bf9
Author: Mattt <mattt@replicate.com>
Date: Tue Jun 27 09:11:03 2023 -0700
Update to Python 3.11 (#1144)
Update dependencies to latest versions
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit d1c0557507995e4abb45366a04141465398eae07
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 27 03:05:37 2023 -0700
Bump mypy from 1.4.0 to 1.4.1 (#1137)
Bumps [mypy](https://github.com/python/mypy) from 1.4.0 to 1.4.1.
- [Commits](https://github.com/python/mypy/compare/v1.4.0...v1.4.1)
---
updated-dependencies:
- dependency-name: mypy
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 1ef278084e9a094e9c5fc8b42d404a17557016a4
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 27 02:57:35 2023 -0700
Bump ruff from 0.0.272 to 0.0.275 (#1141)
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.0.272 to 0.0.275.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md)
- [Commits](https://github.com/astral-sh/ruff/compare/v0.0.272...v0.0.275)
---
updated-dependencies:
- dependency-name: ruff
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 443e27c10cc97ee91a2d73a3825044b2a4739981
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 27 02:57:24 2023 -0700
Bump responses from 0.22.0 to 0.23.1 (#1138)
Bumps [responses](https://github.com/getsentry/responses) from 0.22.0 to 0.23.1.
- [Release notes](https://github.com/getsentry/responses/releases)
- [Changelog](https://github.com/getsentry/responses/blob/master/CHANGES)
- [Commits](https://github.com/getsentry/responses/compare/0.22.0...0.23.1)
---
updated-dependencies:
- dependency-name: responses
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit a6d2bc256490c2abb4f83f392168e735ca1efc67
Author: Hongchao Deng <hongchaodeng1@gmail.com>
Date: Sun Jun 25 17:05:55 2023 +0800
doc: add best practices to building images (#1054)
* doc: add best practices to building images
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
* Formatting
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Rewrite best practices as a callout
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* add doc for weights and others in same dir
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
* Rewrite callout in response to Zeke's feedback
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Mattt Zmuda <mattt@replicate.com>
commit e73a501d451cba2210b438626aaadf65d322ddec
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sun Jun 25 01:25:09 2023 -0700
Bump hypothesis from 6.76.0 to 6.79.2 (#1130)
Bumps [hypothesis](https://github.com/HypothesisWorks/hypothesis) from 6.76.0 to 6.79.2.
- [Release notes](https://github.com/HypothesisWorks/hypothesis/releases)
- [Commits](https://github.com/HypothesisWorks/hypothesis/compare/hypothesis-python-6.76.0...hypothesis-python-6.79.2)
---
updated-dependencies:
- dependency-name: hypothesis
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit d122f31bf2cd968cee953631e8c8a49b4b5ec9ef
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sun Jun 25 01:24:25 2023 -0700
Bump pydantic from 1.10.8 to 1.10.9 (#1122)
Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.8 to 1.10.9.
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](https://github.com/pydantic/pydantic/compare/v1.10.8...v1.10.9)
---
updated-dependencies:
- dependency-name: pydantic
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 3f844f7f72f88d1804e1e36d93c6b1cffce94ac3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sun Jun 25 01:24:17 2023 -0700
Bump pytest from 7.3.2 to 7.4.0 (#1132)
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.3.2 to 7.4.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest/compare/7.3.2...7.4.0)
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 6eb99af269428b974c915baf90e42dbc14629203
Author: Mattt <mattt@replicate.com>
Date: Thu Jun 22 13:48:47 2023 -0700
Update Dependabot configuration (#1127)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 484aeb661bd838775cbe75d87b198b15767264b7
Author: Mattt <mattt@replicate.com>
Date: Thu Jun 22 12:23:59 2023 -0700
Configure git user in test_build_gpu_model_on_cpu (#1124)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 7d8b0d33df7d834d97f7e266eab1469e432d0273
Author: Mattt <mattt@replicate.com>
Date: Thu Jun 22 11:49:50 2023 -0700
Copy weights after installing Python dependencies and running setup commands (#1118)
* Copy weights after installing Python dependencies
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Copy weights after running setup commands
Rename run to runCommands
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Update expected Dockerfile output in tests
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit ed679ac6819849548b29c287d1a37c2fc58a8d69
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Thu Jun 22 11:38:51 2023 -0700
Bump pytest-httpserver from 1.0.6 to 1.0.8 (#1115)
Bumps [pytest-httpserver](https://github.com/csernazs/pytest-httpserver) from 1.0.6 to 1.0.8.
- [Changelog](https://github.com/csernazs/pytest-httpserver/blob/master/CHANGES.rst)
- [Commits](https://github.com/csernazs/pytest-httpserver/compare/1.0.6...1.0.8)
---
updated-dependencies:
- dependency-name: pytest-httpserver
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit b0e5d4bfbe8328317015e1a71383bb1ebd3d8dd2
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Thu Jun 22 11:38:40 2023 -0700
Bump fastapi from 0.96.0 to 0.97.0 (#1116)
Bumps [fastapi](https://github.com/tiangolo/fastapi) from 0.96.0 to 0.97.0.
- [Release notes](https://github.com/tiangolo/fastapi/releases)
- [Commits](https://github.com/tiangolo/fastapi/compare/0.96.0...0.97.0)
---
updated-dependencies:
- dependency-name: fastapi
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit d774c8c4f521f0caf5c5f1b537a5909ef985d813
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Thu Jun 22 11:38:26 2023 -0700
Bump urllib3 from 2.0.2 to 2.0.3 (#1117)
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](https://github.com/urllib3/urllib3/compare/2.0.2...2.0.3)
---
updated-dependencies:
- dependency-name: urllib3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 6f94007549e445e2a1988a274b08d71d4236e01d
Author: Mattt <mattt@replicate.com>
Date: Thu Jun 22 06:07:46 2023 -0700
Update VSCode recommended extensions and settings (#1119)
* Update list of recommended extensions
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Configure Black as default formatter
Enable Ruff autofix on save
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Run black formatter
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Ignore S603 and S607 in test-integration
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix ruff violation in is_port_in_use
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 2c04f26ad1bc02c0d2e306d7b1e75b322728f4e2
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 21 06:46:57 2023 -0700
Automatically set `DOCKER_DEFAULT_PLATFORM=linux/amd64` when running `cog predict` on M1/M2 Macs (#1114)
* Set DOCKER_DEFAULT_PLATFORM=linux/amd64 for docker run on Apple Silicon
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Rename helper method to IsAppleSiliconMac
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Add comments for similar Apple silicon workarounds
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit dfff002e275cdb6af8af4cc290e976813a4a8735
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 21 04:53:27 2023 -0700
Fix instructions for Windows 11 (#1113)
* Formatting
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Run PowerShell as administrator
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Update instructions for installing cuda-toolkit-11-7
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 07cec363be4a68cd401b90edd91e57dc9949bac7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 21 04:28:15 2023 -0700
Bump pytest from 7.3.1 to 7.3.2 (#1107)
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.3.1 to 7.3.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest/compare/7.3.1...7.3.2)
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 20f991738d9b7429e01dd2f12e45de8b4a10f896
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 21 04:28:05 2023 -0700
Bump werkzeug from 2.3.4 to 2.3.6 (#1110)
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 2.3.4 to 2.3.6.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/werkzeug/compare/2.3.4...2.3.6)
---
updated-dependencies:
- dependency-name: werkzeug
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 390c3d0f2b0a2e8720baf46d131e9ad7344c8419
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 21 04:27:53 2023 -0700
Bump github.com/golangci/golangci-lint from 1.50.1 to 1.53.3 (#1108)
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.50.1 to 1.53.3.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.50.1...v1.53.3)
---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit bcfa742d0a5f46df35a6469eec8cb529d1049f70
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 21 04:27:41 2023 -0700
Bump mypy from 0.990 to 1.4.0 (#1109)
Bumps [mypy](https://github.com/python/mypy) from 0.990 to 1.4.0.
- [Commits](https://github.com/python/mypy/compare/v0.990...v1.4.0)
---
updated-dependencies:
- dependency-name: mypy
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 90db7a0587e852d3cb4c42bc5b2c2d42478fc33f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Jun 21 04:15:02 2023 -0700
Bump github.com/moby/term (#1106)
Bumps [github.com/moby/term](https://github.com/moby/term) from 0.0.0-20201110203204-bea5bbe245bf to 0.5.0.
- [Commits](https://github.com/moby/term/commits/v0.5.0)
---
updated-dependencies:
- dependency-name: github.com/moby/term
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit bdccabadfcb1ce8ce41c7b8f82743649611d2b6f
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 21 04:01:12 2023 -0700
Update `cog init` template to use Python 3.11 (#1112)
* Update default version of Python to 3.11
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Fix indentation of commented code
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit c4aa2e1c0862924ab3e97e60ad4014ba5c6cc8f2
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 21 03:52:19 2023 -0700
Change logging level to info when unable to determine Git commit or tag (#1111)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 8f11e786848733fb6a63618f82df84b345f3c64e
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 21 02:55:26 2023 -0700
Check whether port is already in use before starting HTTP server (#1103)
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit e5efe0b166f83a5dc990a75ad2f2843f4bed00b6
Author: Mattt <mattt@replicate.com>
Date: Wed Jun 21 02:55:14 2023 -0700
Copy weights using `--link` option (#1104)
* Use docker/dockerfile:1.4 syntax
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Add --link option to COPY command for weights
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Inline M1 Mac arguments
Always use buildx build
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Replace BUILDKIT_INLINE_CACHE with --cache-to type=inline
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Don't set DOCKER_BUILDKIT
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
* Move declaration of inline Dockerfile for consistency
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
commit 66768a3b131c338aef60b681e138d3cb05066350
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 20 10:16:10 2023 +0000
Bump github.com/spf13/cobra from 1.6.1 to 1.7.0 (#1074)
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.6.1...v1.7.0)
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 1d4fcb1eb04854b8fb05c53c78c1bb5496d6f9ee
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 20 03:08:02 2023 -0700
Bump ruff from 0.0.270 to 0.0.272 (#1076)
Bumps [ruff](https://github.com/charliermarsh/ruff) from 0.0.270 to 0.0.272.
- [Release notes](https://github.com/charliermarsh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md)
- [Commits](https://github.com/charliermarsh/ruff/compare/v0.0.270...v0.0.272)
---
updated-dependencies:
- dependency-name: ruff
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit c05aab675a8b5498fbb05540b68f0208bf792ede
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 20 03:07:49 2023 -0700
Bump pytest-xdist from 3.1.0 to 3.3.1 (#1077)
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.1.0 to 3.3.1.
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.1.0...v3.3.1)
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit fe784d1f3913d4af8343183213044a5a15e2aafb
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 20 03:07:37 2023 -0700
Bump attrs from 22.2.0 to 23.1.0 (#1080)
Bumps [attrs](https://github.com/python-attrs/attrs) from 22.2.0 to 23.1.0.
- [Release notes](https://github.com/python-attrs/attrs/releases)
- [Changelog](https://github.com/python-attrs/attrs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/python-attrs/attrs/compare/22.2.0...23.1.0)
---
updated-dependencies:
- dependency-name: attrs
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit b396eeacd4372ce603e851708310657955af7fa9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 20 03:07:14 2023 -0700
Bump github.com/stretchr/testify from 1.8.1 to 1.8.4 (#1091)
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.1 to 1.8.4.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.8.1...v1.8.4)
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit a019831e448e9f5437ae91bfe9cc2b3739e6ff5e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Jun 20 03:07:00 2023 -0700
Bump golang.org/x/tools from 0.4.0 to 0.10.0 (#1092)
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.4.0 to 0.10.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/compare/v0.4.0...v0.10.0)
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit fa5c1a4a6c68e17f1fba494e2404ae5bf92ca5e3
Author: Hongchao Deng <hongchaodeng1@gmail.com>
Date: Tue Jun 20 17:59:46 2023 +0800
fix: take into account user specified image name (#1097)
* fix: take into account user specified image name
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
* Extract common --no-weights-image flag into shared helper function
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Mattt Zmuda <mattt@replicate.com>
commit 418b8455fe4aa809502f33bc8f5ca84291af8ba7
Author: Hongchao Deng <hongchaodeng1@gmail.com>
Date: Tue Jun 20 17:43:01 2023 +0800
fix: respects existing contents in .dockerignore (#1101)
* fix: respects existing contents in .dockerignore
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
* Apply suggestions from code review
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
---------
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Mattt Zmuda <mattt@replicate.com>
commit 48cfef255081393c2e6c88d1e8a7b08d2b6db436
Author: Hongchao Deng <hongchaodeng1@gmail.com>
…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1214 we accidentally left it so pyenv is installed when gpu: true even if --use-cuda-base-image=false. This PR fixes that.