chore: set -buildvcs=false on go build
#2516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default go 1.18+ injects version control info into main packages on build. That's fine. But it's buggy and we don't need it anyway since goreleaser does it for us. So I'm disabling it. Why? If you're building from a linked git worktree (which I do all the time) it'll bomb because go expects the `.git` directory to be the common git root, not a pointer to one. It's a longstanding bug that'll maybe get fixed by go 3.0 golang/go#58218
tjex
added a commit
to zk-org/zk
that referenced
this pull request
Sep 7, 2025
It breaks when building in worktrees and isn't necessary for us, as we're injecting the version ourselves anyway. It will also be set to false by default in upcoming go version: replicate/cog#2516
meatballhat
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default go 1.18+ injects version control info into main packages on build. That's fine. But it's buggy and we don't need it anyway since goreleaser does it for us. So I'm disabling it.
Why? If you're building from a linked git worktree (which I do all the time) it'll bomb because go expects the
.gitdirectory to be the common git root, not a pointer to one. It's a longstanding bug that'll maybe get fixed by go 3.0 golang/go#58218