Skip to content

Conversation

@dtmeadows
Copy link
Collaborator

@dtmeadows dtmeadows commented May 9, 2025

  • ports over support from the old run() helper to be able to upload files within run() if we're not doing base64 encoding
  • adds tests for this too!

todo:

  • one small thing about a custom code change I need to run by @zeke

@dtmeadows dtmeadows requested a review from zeke May 9, 2025 20:14
@dtmeadows dtmeadows changed the base branch from main to next May 9, 2025 20:15
@stainless-app stainless-app bot requested a review from a team as a code owner May 13, 2025 02:31
@dtmeadows
Copy link
Collaborator Author

@zeke this is ready for a final review!

Copy link
Member

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

What are your thoughts on how to document replicate.run() in this client?

@dgellow
Copy link
Collaborator

dgellow commented Jun 10, 2025

@zeke I will merge this PR as-is for now, and will do another pass to be sure it is aligned with the typescript client.

Regarding docs, the typescript client has docs in README + some docstrings, I feel we should do the same here? And likely add an example that covers the various way to use run()

@dgellow dgellow merged commit 66bdf62 into next Jun 10, 2025
2 checks passed
@dgellow dgellow deleted the dmeadows/use-files-in-run branch June 10, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants