Skip to content

Update Dockerfile #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2019
Merged

Update Dockerfile #102

merged 1 commit into from
Jan 3, 2019

Conversation

@AlexBeggs
Copy link
Contributor

  • Use smaller Alpine base image
  • Image goes from 759MB to 218MB, just under 3.5 times smaller
  • Update Dockerfile to comply with lint issues

@AlexBeggs
Update Dockerfile
2d9ec38 
Use smaller Alpine base image
@coveralls
Copy link

coveralls commented Jun 1, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.16% when pulling 2d9ec38 on sunyal:patch-1 into ad65813 on replicatedhq:master.

@fshot fshot self-requested a review January 3, 2019 22:21
@fshot fshot merged commit c860dd8 into replicatedhq:master Jan 3, 2019
@fshot
Copy link

fshot commented Jan 3, 2019

Thanks for the PR, @sunyal , and apologies for the delay in reviewing & merging it in!

svl7 pushed a commit to svl7/dockerfilelint that referenced this pull request Jun 22, 2020
Merge pull request replicatedhq#102 from sunyal/patch-1
5a6d676 
Update Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fshot fshot fshot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexBeggs @coveralls @fshot