bug: do not overwrite kubeconfig on error #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if k0sctl kubeconfig fails we can't overwrite the kubeconfig file with the error message returned. this commit solves it.
emosbaugh
approved these changes
Aug 18, 2023
emosbaugh
pushed a commit
that referenced
this pull request
Aug 26, 2024
today users can have one configuration provided through the kots application but they can also provide overrides through the command line when installing a cluster (--overrides flag). this commit adds a property to the crd so we can keep track of the overrides used at install time as well as the config embedded through the kots app. this commit also moves from keeping the whole config obect to holds only its spec (we don't care about config status).
emosbaugh
pushed a commit
that referenced
this pull request
Aug 30, 2024
…uild-issues import github.com/k0sproject/k0s@v1.28.8+k0s.0 to allow for upgrade testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if k0sctl kubeconfig fails we can't overwrite the kubeconfig file with the error message returned. this commit solves it.